Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish button hidden by "The image will be uploaded in the background as soon as possible" when adding new product #3963

Closed
Tracked by #1379
benbenben2 opened this issue May 13, 2023 · 7 comments
Assignees
Labels
🐛 bug Something isn't working layout Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.

Comments

@benbenben2
Copy link

benbenben2 commented May 13, 2023

What

When uploading picture, the message "The image will be uploaded in the background as soon as possible" is hiding the button "Finish" button.

Steps to reproduce the behavior

Simply upload picture or add basic details on new product.

Expected behavior

It should be possible to click on the "Finish".

Why

If we cannot click on the "Finish" button, we have to wait a couple of seconds. Which can waste quite some time if we want to add many new products.

Part of

Screenshot/Mockup/Before-After

Screenshot_20230505

@monsieurtanuki
Copy link
Contributor

Hi @benbenben2!
I was able to reproduce this issue for photo upload. That is not the case for basic details, where the floating action button is pushed upwards by the snackbar.
It seems to be caused by the fact that in the crop page the "send!" button is not a floating action button.

@monsieurtanuki
Copy link
Contributor

@teolemon The thing is that we need a floating action button in both the crop page and in "add new product" page.
And we switch from FAB in crop page months ago.

@monsieurtanuki
Copy link
Contributor

@benbenben2 Btw the "finish" button is useless. I mean, you get the same result if you go back one page.

@teolemon
Copy link
Member

We could add a close cross in the topbar then ?

@monsieurtanuki monsieurtanuki self-assigned this May 13, 2023
@monsieurtanuki
Copy link
Contributor

We could add a close cross in the topbar then ?

@teolemon Unfortunately, not exactly.
I've just tried to do so. That works until you upload an image (!). Then the standard cross disappears (as does a standard back button).
Something wrong with the image crop, obviously. Probably because we escape the app and go to the gallery or the camera: when we go back we sort of lose the history of why we're in this page. Therefore no page to go back to.
Or something like that...

landing on the page after an upload
Screenshot_2023-05-13-16-09-30 Screenshot_2023-05-13-16-09-49

@teolemon teolemon added Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. layout labels May 18, 2023
@monsieurtanuki
Copy link
Contributor

@benbenben2 The "add new product" page has been heavily refactored, and there's no "finish" button anymore (just the "back" button in the app bar).
Therefore, the issue is somehow solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working layout Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.
Development

No branches or pull requests

3 participants