Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Common layout for welcome / product not found / error cards #2955

Merged
merged 7 commits into from
Sep 7, 2022
Merged

feat: Common layout for welcome / product not found / error cards #2955

merged 7 commits into from
Sep 7, 2022

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Sep 7, 2022

What

  • On small devices, carousel cards may overflow
  • On all devices, cards don't have the same width/height

Simulator Screen Shot - iPod touch (7th generation) - 2022-09-07 at 08 13 02
Simulator Screen Shot - iPod touch (7th generation) - 2022-09-07 at 08 13 07
Simulator Screen Shot - iPod touch (7th generation) - 2022-09-07 at 08 18 05

@g123k g123k self-assigned this Sep 7, 2022
@g123k g123k requested a review from a team as a code owner September 7, 2022 06:26
@g123k
Copy link
Collaborator Author

g123k commented Sep 7, 2022

(The test error is coming from the PR related to the scanner #2953)

@g123k g123k force-pushed the carousel_small_devices branch from ed170a2 to e991e32 Compare September 7, 2022 06:32
@AshAman999
Copy link
Member

image

I think the text doesn't look in center on the screen, would be better and consistent if made in center

@g123k
Copy link
Collaborator Author

g123k commented Sep 7, 2022 •
edited
Loading

image

I think the text doesn't look in center on the screen, would be better and consistent if made in center

It wasn't before, so I have let it "as-is". Anyone else with an advice on this?

@monsieurtanuki
Copy link
Contributor

It wasn't before, so I have let it "as-is". Any else with an advice on this?

The big icon is explicit enough that something bad happened: remove the (!) icon and center the text.

monsieurtanuki
monsieurtanuki approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @g123k!
I have minor comments; feel free to ignore them.

I haven't followed everything this morning, but it looks like there's a pending error that will pollute all the upcoming PRs and this error is connected to camera - that's why I believe you would know how to fix it, in another PR.

packages/smooth_app/lib/widgets/smooth_product_carousel.dart Outdated Show resolved Hide resolved
packages/smooth_app/lib/cards/product_cards/smooth_product_card.dart Outdated Show resolved Hide resolved
packages/smooth_app/lib/cards/product_cards/smooth_product_card_not_found.dart
import 'package:smooth_app/pages/product/add_new_product_page.dart';

class SmoothProductCardNotFound extends StatelessWidget {
const SmoothProductCardNotFound({
SmoothProductCardNotFound({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not const anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, since there is a callback, the Widget can never be "constant"

@teolemon teolemon merged commit 77569bf into openfoodfacts:develop Sep 7, 2022
@github-actions github-actions bot mentioned this pull request Sep 7, 2022
Merged
@g123k g123k deleted the carousel_small_devices branch September 10, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monsieurtanuki monsieurtanuki monsieurtanuki approved these changes

Assignees

@g123k g123k

Labels
product scan carousel scan card
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@g123k @AshAman999 @monsieurtanuki @teolemon