-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Alternative mode for camera (Android only feature) #2953
Conversation
An open question: we have a list of whitelisted devices (eg: OnePlus smartphones). |
|
Or even log the device name when opening this settings, and using matomo, we should be able to see successful scans |
This is a nice idea. To be honest I wonder if it shouldn't be the new default mode |
Given all the pain in the neck around the camera, if you found a more reliable code I agree that we should use it as the default mode. |
The drawback with this new solution is that it consumes more I/O on the storage, but less memory. Some devices use microSD and in that case, I'm not entirely sure what it can give in terms of performance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big fan of the dynamic typing but thats fine, the code looks fine to me. Lets merge, test and then decide if we change to default mode
That's idea here, a first implementation to test if the scanner works better and I will create a second PR to improve things accordingly 👍 |
ok, merging |
What
The MLKit plugin doesn't work on some devices with a byte array, but is OK when passing a file instead.
The native plugin (camera) is able to both provide a byte array or a file only on Android (as iOS seems OK).
The PR allows switching between the two modes.
Here is the screenshot of the new setting (only visible on Android)
Some notes:
Related to #2741