Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develope broken by camera fork #2963

Closed
M123-dev opened this issue Sep 7, 2022 · 3 comments
Closed

Develope broken by camera fork #2963

M123-dev opened this issue Sep 7, 2022 · 3 comments
Assignees
@g123k
Labels
🐛 bug Something isn't working 🎯 P0

Comments

@M123-dev
Copy link
Member

M123-dev commented Sep 7, 2022

What

  error • 'SmoothCameraController.startImageStream' ('Future<void> Function(dynamic Function(dynamic))') isn't a valid override of 'CameraController.startImageStream' ('Future<void> Function(dynamic Function(dynamic), {bool persistToFile})') • packages/smooth_app/lib/pages/scan/camera_controller.dart:94:16 • invalid_override
  error • The argument type 'void Function(CameraImage)' can't be assigned to the parameter type 'dynamic Function(dynamic)' • packages/smooth_app/lib/pages/scan/ml_kit_scan_page.dart:304:22 • argument_type_not_assignable
@M123-dev M123-dev added 🐛 bug Something isn't working 🎯 P0 labels Sep 7, 2022
@g123k
Copy link
Collaborator

g123k commented Sep 7, 2022

Yes I know, but the easiest way would be to review this PR in priority.

@M123-dev M123-dev mentioned this issue Sep 7, 2022
Merged
@M123-dev
Copy link
Member Author

M123-dev commented Sep 7, 2022

#2953 or which one

@g123k
Copy link
Collaborator

g123k commented Sep 7, 2022

Yes it was #2953

@g123k g123k closed this as completed Sep 7, 2022
Repository owner moved this from To discuss and validate to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g123k g123k

Labels
🐛 bug Something isn't working 🎯 P0
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@g123k @M123-dev