Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The product addition check shouldn't look like a radio button #2974

Closed
Tracked by #1379
teolemon opened this issue Sep 8, 2022 · 3 comments · Fixed by #3080
Closed
Tracked by #1379

The product addition check shouldn't look like a radio button #2974

teolemon opened this issue Sep 8, 2022 · 3 comments · Fixed by #3080
Labels
🐛 bug Something isn't working good first issue Good for newcomers 🎯 P1 Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.

Comments

@teolemon
Copy link
Member

teolemon commented Sep 8, 2022 •
edited
Loading

What

-The product addition check shouldn't look like a radio button. Probably something more explicit (colored emoji ?)

Part of
@teolemon teolemon added 🐛 bug Something isn't working good first issue Good for newcomers labels Sep 8, 2022
@monsieurtanuki
Copy link
Contributor

@teolemon For the record those are not radio buttons, but checkboxes:
Capture d’écran 2022-09-08 à 19 09 10

Those are radio buttons:
Capture d’écran 2022-09-08 à 19 09 32

@teolemon teolemon mentioned this issue Sep 12, 2022
Open
@teolemon teolemon changed the title Grace Hopper - The product addition check shouldn't look like a radio button The product addition check shouldn't look like a radio button Sep 18, 2022
@teolemon teolemon added Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🎯 P1 labels Sep 18, 2022
@WildOrangutan
Copy link
Contributor

I can work on this. How should icon look like? I'm scratching my head, what kind of icon to replace it with? Did you had something in mind?

Maybe any of following?

image
image
image

@M123-dev
Copy link
Member

M123-dev commented Oct 1, 2022 •
edited
Loading

I prefer the middle one "Check" maybe even in green @WildOrangutan

@WildOrangutan WildOrangutan mentioned this issue Oct 2, 2022
Merged
M123-dev pushed a commit that referenced this issue Oct 3, 2022
@WildOrangutan
feat: Add checkmarks on 'add new product' screen (#3080)
8b08a85 
* feat: New product basic details checkmark

* refactor: New product page added row

* feat: New product nutrition facts checkmark

* chore: Fix new product page code formatting

* fix: Change icon on new product page

Closes: #2974

* refactor: Add new product page added row to widget
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working good first issue Good for newcomers 🎯 P1 Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add checkmarks on 'add new product' screen
4 participants
@teolemon @WildOrangutan @monsieurtanuki @M123-dev