fix: Finish button replaced with FAB #3219

prathamsoni11 · 2022-10-26T03:18:29Z

What

Replaced Finish button with new FAB button Product Addition - The image upload snackbar is blocking the finish button while it's visible #2944

Screenshot

Fixes bug(s)

Part of

Product Addition - The image upload snackbar is blocking the finish button while it's visible #2944

chore: Update assets

…into develop

monsieurtanuki · 2022-10-26T13:32:03Z

packages/smooth_app/lib/pages/product/add_new_product_page.dart

                Positioned(
                  child: Align(
-                    alignment: Alignment.bottomCenter,
-                    child: SmoothActionButtonsBar.single(
-                      action: SmoothActionButton(
-                        text: appLocalizations.finish,
-                        onPressed: () async {
-                          final LocalDatabase localDatabase =
-                              context.read<LocalDatabase>();
-                          final DaoProduct daoProduct =
-                              DaoProduct(localDatabase);
-                          final Product? localProduct =
-                              await daoProduct.get(widget.barcode);
-                          if (localProduct == null) {
-                            product = Product(
-                              barcode: widget.barcode,
-                            );
-                            daoProduct.put(product);
-                            localDatabase.notifyListeners();
-                          }
-                          provider.set(product);
-                          if (mounted) {
-                            await Navigator.maybePop(context,
-                                _isProductLoaded ? widget.barcode : null);
-                          }
-                        },
-                      ),
+                    alignment: Alignment.bottomRight,
+                    child: FloatingActionButton.extended(


Forget about Positioned and Align: just use the floatingActionButton parameter of SmoothScaffold.

This type of behaviour SmoothScaffold is showing.

This looks like similar to your initial screenshot, isn't-it?

Yes, it is similar but SmoothScaffold is hiding other contents on the screen. So that thing is making a difference

Here I found something to display other screen stuff by using the background colour property in SmoothScaffold as transparent

@monsieurtanuki @g123k should I commit this code?

@prathamsoni11 It looks like you removed the body from the SmoothScaffold: that would explain the empty screen.

@monsieurtanuki @g123k Done it is now ready to be merged.

monsieurtanuki

Hi @prathamsoni11!
Please

remove the Stack as well: we don't need it anymore
attach a screenshot

prathamsoni11 · 2022-10-27T14:38:09Z

Hi @prathamsoni11! Please

remove the Stack as well: we don't need it anymore

attach a screenshot

@monsieurtanuki @g123k Removed Stack

monsieurtanuki

LGTM @prathamsoni11!

g123k · 2022-10-27T14:48:33Z

Way better, but does it still overlaps the button on small screens?

monsieurtanuki · 2022-10-27T14:53:02Z

Way better, but does it still overlaps the button on small screens?

@g123k I don't see why it should not: a FAB is on top of anything.
The solution for that would be to add a bottom padding to the SingleChildScrollView (cf. the standard size + position of a FAB).

g123k · 2022-10-27T14:54:43Z

Way better, but does it still overlaps the button on small screens?

@g123k I don't see why it should not: a FAB is on top of anything.
The solution for that would be to add a bottom padding to the SingleChildScrollView (cf. the standard size + position of a FAB).

+1 it would even be better if we could add this padding only if needed (by computing the size)

monsieurtanuki · 2022-10-27T14:58:30Z

+1 it would even be better if we could add this padding only if needed (by computing the size)

Would it?

If we put an extra padding on a large screen, it will be useless and will have no impact
If we put an extra padding on a small screen, it will be useful and will have an impact
So the extra padding only has a positive impact (and no negative impact).

g123k · 2022-10-27T15:16:30Z

If we do so, the overscroll will be ugly on large screens

monsieurtanuki · 2022-10-27T15:18:25Z

If we do so, the overscroll will be ugly on large screens

I cannot picture that. Could you share a screenshot?

g123k · 2022-10-27T15:20:46Z

The overscroll is this "glow" effect: https://i.stack.imgur.com/6mMn4.png

By adding a padding it will add a blank space on the bottom, which won't be nice.

monsieurtanuki · 2022-10-27T15:27:17Z

The overscroll is this "glow" effect: https://i.stack.imgur.com/6mMn4.png
By adding a padding it will add a blank space on the bottom, which won't be nice.

That's what I would call a cosmetic issue, with low priority. And IMHO fixing this cosmetic issue will bring additional confusion to the code.
That said, as long as I'm not involved in it, feel free to spend your time where you find it appropriate.

monsieurtanuki · 2022-10-28T17:24:50Z

Thank you @prathamsoni11!

prathamsoni11 · 2022-10-28T17:26:58Z

Thank you @prathamsoni11!

Your Welcome sir @monsieurtanuki 😀

prathamsoni11 and others added 14 commits October 3, 2022 19:20

Update assets

bc52e3b

Merge pull request #6 from prathamsoni11/auto-update-assets

1e9c2b4

chore: Update assets

Merge branch 'develop' of https://github.com/prathamsoni11/smooth-app …

19e5564

…into develop

Merge branch 'openfoodfacts:develop' into develop

8456a4a

Merge branch 'openfoodfacts:develop' into develop

625ea11

Merge branch 'develop' of https://github.com/prathamsoni11/smooth-app …

5c1d2ba

…into develop

Merge branch 'develop' of https://github.com/prathamsoni11/smooth-app …

a80e2fc

…into develop

Merge branch 'develop' of https://github.com/prathamsoni11/smooth-app …

542c472

…into develop

Merge branch 'develop' of https://github.com/prathamsoni11/smooth-app …

c395057

…into develop

Merge branch 'openfoodfacts:develop' into develop

e6ffbf0

Merge branch 'openfoodfacts:develop' into develop

bc79635

Merge branch 'openfoodfacts:develop' into develop

7ae9401

Merge branch 'openfoodfacts:develop' into develop

dc5f878

changed button with FAB

a3e6306

prathamsoni11 requested a review from a team as a code owner October 26, 2022 03:18

github-actions bot assigned prathamsoni11 Oct 26, 2022

github-actions bot added Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page labels Oct 26, 2022

monsieurtanuki reviewed Oct 26, 2022

View reviewed changes

github-actions bot added the PR: needs rebase label Oct 27, 2022

moved FAB in SmoothScaffold

2c246aa

monsieurtanuki reviewed Oct 27, 2022

View reviewed changes

removed stack

14e66f7

monsieurtanuki approved these changes Oct 27, 2022

View reviewed changes

Merge branch 'develop' into finish_button

8e4884f

github-actions bot removed the PR: needs rebase label Oct 28, 2022

monsieurtanuki added 2 commits October 28, 2022 18:27

Update add_new_product_page.dart

8e7f0c4

Merge branch 'develop' into finish_button

b69f077

monsieurtanuki merged commit 796257f into openfoodfacts:develop Oct 28, 2022

github-actions bot mentioned this pull request Oct 28, 2022

chore(develop): release 4.0.0 #3159

Merged

M123-dev added this to the v4 milestone Nov 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Finish button replaced with FAB #3219

fix: Finish button replaced with FAB #3219

prathamsoni11 commented Oct 26, 2022

monsieurtanuki Oct 26, 2022

prathamsoni11 Oct 26, 2022

g123k Oct 26, 2022

prathamsoni11 Oct 26, 2022 •

edited

Loading

prathamsoni11 Oct 26, 2022

prathamsoni11 Oct 27, 2022

monsieurtanuki Oct 27, 2022

prathamsoni11 Oct 27, 2022

monsieurtanuki left a comment

prathamsoni11 commented Oct 27, 2022 •

edited

Loading

monsieurtanuki left a comment

g123k commented Oct 27, 2022

monsieurtanuki commented Oct 27, 2022

g123k commented Oct 27, 2022

monsieurtanuki commented Oct 27, 2022

g123k commented Oct 27, 2022

monsieurtanuki commented Oct 27, 2022

g123k commented Oct 27, 2022

monsieurtanuki commented Oct 27, 2022

monsieurtanuki commented Oct 28, 2022

prathamsoni11 commented Oct 28, 2022

fix: Finish button replaced with FAB #3219

fix: Finish button replaced with FAB #3219

Conversation

prathamsoni11 commented Oct 26, 2022

What

Screenshot

Fixes bug(s)

Part of

monsieurtanuki Oct 26, 2022

Choose a reason for hiding this comment

prathamsoni11 Oct 26, 2022

Choose a reason for hiding this comment

g123k Oct 26, 2022

Choose a reason for hiding this comment

prathamsoni11 Oct 26, 2022 • edited Loading

Choose a reason for hiding this comment

prathamsoni11 Oct 26, 2022

Choose a reason for hiding this comment

prathamsoni11 Oct 27, 2022

Choose a reason for hiding this comment

monsieurtanuki Oct 27, 2022

Choose a reason for hiding this comment

prathamsoni11 Oct 27, 2022

Choose a reason for hiding this comment

monsieurtanuki left a comment

Choose a reason for hiding this comment

prathamsoni11 commented Oct 27, 2022 • edited Loading

monsieurtanuki left a comment

Choose a reason for hiding this comment

g123k commented Oct 27, 2022

monsieurtanuki commented Oct 27, 2022

g123k commented Oct 27, 2022

monsieurtanuki commented Oct 27, 2022

g123k commented Oct 27, 2022

monsieurtanuki commented Oct 27, 2022

g123k commented Oct 27, 2022

monsieurtanuki commented Oct 27, 2022

monsieurtanuki commented Oct 28, 2022

prathamsoni11 commented Oct 28, 2022

prathamsoni11 Oct 26, 2022 •

edited

Loading

prathamsoni11 commented Oct 27, 2022 •

edited

Loading