feat: new localized label 'sep' as separator before colon (especially in French) #3753
Conversation
This reverts commit ad46236.
# Conflicts: # packages/smooth_app/pubspec.lock # packages/smooth_app/pubspec.yaml
… in French) Impacted files: * `app_en.arb`: new label `'sep'` as separator before colon; minor consistency fix * `app_fr.arb`: new label `'sep'` as separator before colon; minor consistency fixes
Codecov Report
@@ Coverage Diff @@
## develop #3753 +/- ##
========================================
Coverage 10.40% 10.40%
========================================
Files 272 272
Lines 13835 13835
========================================
Hits 1440 1440
Misses 12395 12395 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| "sep": "", | ||
| "@sep": { | ||
| "description": "Separator just before a colon (':'). Probably only populated in French and empty in other languages." | ||
| }, |
There was a problem hiding this comment.
I've read the discussion in the other PR but do we really need this, shouldn't these spaces be added in the Strings itself as you did in the app_fr.arb
There was a problem hiding this comment.
@M123-dev You're right, we don't need it as long as we have full sentences already localized.
But if we want to build a String with very specific business rules, we need this extra label. Off server needed it. And that would be used in the referenced PR.
Should the referenced PR use a colon rather than a comma, that's another story.
There was a problem hiding this comment.
On the server side, there are many places where we display a field name, a colon and a value. (e.g. "Categories: Coffees"). We do that with something that looks like [field name][sep]: [value], so that in French we can have "Catégories : Cafés".
There was a problem hiding this comment.
I couldn't say why but that's never happened before in Smoothie.
Perhaps because we rather concatenate Widgets than Strings, or because the most verbose things come directly from the server as KP.
|
Thank you @stephanegigandet for the review! |
Impacted files:
app_en.arb: new label'sep'as separator before colon; minor consistency fixapp_fr.arb: new label'sep'as separator before colon; minor consistency fixesWhat
Part of