feat: 3585 - upgrade to flutter 3.7 #3666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `account_deletion_webview.dart`: minor refactoring; could not test, unfortunately * `background_task_badge.dart`: minor refactoring * `camera_scan_page.dart`: minor refactoring * `country_selector.dart`: minor refactoring * `generated_plugin_registrant.cc`: wtf * `generated_plugins.cmake`: wtf * `GeneratedPluginRegistrant.swift`: wtf * `Info.plist`: wtf * `knowledge_panel_world_map_card.dart`: minor refactoring * `network_config.dart`: minor refactoring * `Podfile.lock`: wtf * `product_query_page.dart`: minor refactoring * `project.pbxproj`: wtf * `pubspec.lock`: wtf * `apple_app_store/pubspec.yaml`: to dart 2.19 without restriction for flutter * `google_play/pubspec.yaml`: to dart 2.19 without restriction for flutter * `app_store/shared/pubspec.yaml`: to dart 2.19 without restriction for flutter * `uri_store/pubspec.yaml`: to dart 2.19 without restriction for flutter * `data_importer/pubspec.yaml`: to dart 2.19 without restriction for flutter * `data_importer_shared/pubspec.yaml`: to dart 2.19 without restriction for flutter * `mlkit/pubspec.yaml`: to dart 2.19 without restriction for flutter * `scanner/shared/pubspec.yaml`: to dart 2.19 without restriction for flutter * `zxing/pubspec.yaml`: to dart 2.19 without restriction for flutter * `smooth_app/pubspec.yaml`: to dart 2.19 without restriction for flutter; upgraded the versions * `user_preferences_page_test.dart`: minor refactoring
github-actions
bot
added
dependencies
🍎 iOS
M123-dev
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
Looks good to me, thanks @monsieurtanuki are you able to again run the app
Not really: cannot compile on iOS for the moment (because apple stinks), and cannot run the app more than once on my Android smartphone (because of the months old bug regarding camera). |
|
Just from looking at it, I would say, merge and test out in the internal release. Though there seems to be a problem with the web view https://github.com/openfoodfacts/smooth-app/actions/runs/4067542669/jobs/7005015358#step:8:69 |
|
@M123-dev the thing is that webview is used only in a very specific case ("delete account" or something like that), which is not something we use everyday. Additional thoughts:
|
Impacted file: * `user_preferences_page_test.dart`: minor cheat
Impacted file: * `user_preferences_page_test.dart`: minor cheat
Codecov Report
@@ Coverage Diff @@
## develop #3666 +/- ##
==========================================
- Coverage 10.44% 9.45% -0.99%
==========================================
Files 269 269
Lines 13578 13571 -7
==========================================
- Hits 1418 1283 -135
- Misses 12160 12288 +128
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Feb 4, 2023
monsieurtanuki
added a commit
to monsieurtanuki/smooth-app
that referenced
this pull request
Feb 13, 2023
This reverts commit ad46236.
monsieurtanuki
added a commit
that referenced
this pull request
Feb 14, 2023
monsieurtanuki
added a commit
that referenced
this pull request
Feb 21, 2023
* Revert "feat: 3585 - upgrade to flutter 3.7 (#3666)" This reverts commit ad46236. * fix: 3622 - no autofocus and clean FocusNode management Impacted files: * `edit_new_packagings_component.dart`: applied best practices for `FocusNode` (had to switch to `StatefulWidget` for that) * `Podfile.lock`: wtf * `simple_input_number_field.dart`: removed `autofocus: true` * `simple_input_text_field.dart`: removed `autofocus: true` * `simple_input_widget.dart`: applied best practices for `FocusNode`
monsieurtanuki
added a commit
that referenced
this pull request
Feb 21, 2023
* Revert "feat: 3585 - upgrade to flutter 3.7 (#3666)" This reverts commit ad46236. * chore: off-dart 2.3.1 and its new sorted suggestions Deleted file: * `tmp_matched_product_v2.dart`: now in off-dart Impacted files: * `personalized_ranking_model.dart`: removed reference to now deleted file `tmp_matched_product_v2.dart` * `personalized_ranking_page.dart`: removed reference to now deleted file `tmp_matched_product_v2.dart` * `Podfile.lock`: wtf * `pubspec.lock`: wtf * `pubspec.yaml`: upgraded off-dart to 2.3.1 * `simple_input_text_field.dart`: now using the new `getSuggestions` method that sorts the result
monsieurtanuki
added a commit
that referenced
this pull request
Feb 23, 2023
…3734) * Revert "feat: 3585 - upgrade to flutter 3.7 (#3666)" This reverts commit ad46236. * fix: 3723 - now always replaces decimal separator for number format Impacted files: * `strings_helper.dart`: removed now useless methods * `text_input_formatters_helper.dart`: now works in all cases, regardless of the presence of group separator in the target language, given that we don't use group separators in our decimal number formats anyway * fix: 3723 - unrelated localization fix Impacted file: * `app_ar.arb`
monsieurtanuki
added a commit
that referenced
this pull request
Feb 27, 2023
* Revert "feat: 3585 - upgrade to flutter 3.7 (#3666)" This reverts commit ad46236. * fix: 3723 - additional tests Impacted file: * `text_input_formatters_helper.dart` * fix: 3723 - additional tests Impacted file: * `text_input_formatters_helper.dart` * fix: 3723 - additional tests Impacted file: * `simple_input_number_field.dart` * fix: 3723 - with "assert" Impacted file: * `text_input_formatters_helper.dart`
monsieurtanuki
added a commit
that referenced
this pull request
Feb 28, 2023
* Revert "feat: 3585 - upgrade to flutter 3.7 (#3666)" This reverts commit ad46236. * feat: 3749 - improvements for packaging suggestions Impacted files: * `edit_new_packagings.dart`: added categories parameter for suggestions * `edit_new_packagings_component.dart`: added categories field; added categories parameters for shape search; added categories and shape parameters for material search; added specific minLengthForSuggestions parameter set to 0 for shape and material search * `simple_input_text_field.dart`: added minLengthForSuggestions, categories and shape fields; added categories, shape and country parameters for `getSuggestions`
monsieurtanuki
added a commit
that referenced
this pull request
Mar 2, 2023
… in French) (#3753) * Revert "feat: 3585 - upgrade to flutter 3.7 (#3666)" This reverts commit ad46236. * feat: new localized label 'sep' as separator before colon (especially in French) Impacted files: * `app_en.arb`: new label `'sep'` as separator before colon; minor consistency fix * `app_fr.arb`: new label `'sep'` as separator before colon; minor consistency fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
account_deletion_webview.dart: minor refactoring; could not test, unfortunatelybackground_task_badge.dart: minor refactoringcamera_scan_page.dart: minor refactoringcountry_selector.dart: minor refactoringgenerated_plugin_registrant.cc: wtfgenerated_plugins.cmake: wtfGeneratedPluginRegistrant.swift: wtfInfo.plist: wtfknowledge_panel_world_map_card.dart: minor refactoringnetwork_config.dart: minor refactoringPodfile.lock: wtfproduct_query_page.dart: minor refactoringproject.pbxproj: wtfpubspec.lock: wtfapple_app_store/pubspec.yaml: to dart 2.19 without restriction for fluttergoogle_play/pubspec.yaml: to dart 2.19 without restriction for flutterapp_store/shared/pubspec.yaml: to dart 2.19 without restriction for flutteruri_store/pubspec.yaml: to dart 2.19 without restriction for flutterdata_importer/pubspec.yaml: to dart 2.19 without restriction for flutterdata_importer_shared/pubspec.yaml: to dart 2.19 without restriction for fluttermlkit/pubspec.yaml: to dart 2.19 without restriction for flutterscanner/shared/pubspec.yaml: to dart 2.19 without restriction for flutterzxing/pubspec.yaml: to dart 2.19 without restriction for fluttersmooth_app/pubspec.yaml: to dart 2.19 without restriction for flutter; upgraded the versionsuser_preferences_page_test.dart: minor refactoringWhat
Part of