Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Login] Insufficient contrast for the error banner #3865

Closed
g123k opened this issue Apr 10, 2023 · 1 comment
Closed

[Login] Insufficient contrast for the error banner #3865

g123k opened this issue Apr 10, 2023 · 1 comment

Comments

@g123k
Copy link
Collaborator

g123k commented Apr 10, 2023

Hi everyone,

In the Login screen, the error label is poorly contrasted:
Screenshot_1681124018

A contrast checker for this screen gives:
Screenshot 2023-04-10 at 12 58 33

@monsieurtanuki
Copy link
Contributor

"Incorrect username or password" is an error and should be considered as such, with standard error and onError colors (which is not the case currently).

  • cf ColorScheme.light (which passes the AAA test) (I used https://webaim.org/resources/contrastchecker/)
    • error = const Color(0xffb00020)
    • onError = Colors.white
  • cf ColorScheme.dark (which does not pass the AAA test)
    • error = const Color(0xffcf6679) // with red[300] = Color(0xFFE57373) the test would pass
    • onError = Colors.black

@monsieurtanuki monsieurtanuki added the good first issue Good for newcomers label Apr 12, 2023
anujchoudhary-17 added a commit to anujchoudhary-17/smooth-app that referenced this issue May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants