Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 3865 Insufficient contrast for the error banner #3940

Merged
merged 5 commits into from
May 13, 2023

Conversation

anujchoudhary-17
Copy link
Contributor

What

  • Changed Login Screen Page error banner fontSize and Color.

Screenshot

image

Fixes bug(s)

  • Fixes: UI Color and font fixes

Part of

@anujchoudhary-17 anujchoudhary-17 requested a review from a team as a code owner May 7, 2023 19:51
@github-actions github-actions bot added the 👥 User management Account login, signup, signout label May 7, 2023
@anujchoudhary-17 anujchoudhary-17 changed the title Fixed - [Login] Insufficient contrast for the error banner #3865 - fix - [Login] Insufficient contrast for the error banner #3865 May 7, 2023
@anujchoudhary-17 anujchoudhary-17 changed the title - fix - [Login] Insufficient contrast for the error banner #3865 - fix: 3865 Insufficient contrast for the error banner May 7, 2023
@anujchoudhary-17 anujchoudhary-17 changed the title - fix: 3865 Insufficient contrast for the error banner fix: 3865 Insufficient contrast for the error banner May 7, 2023
@M123-dev M123-dev requested review from g123k and monsieurtanuki May 8, 2023 06:32
@teolemon teolemon added the colors label May 9, 2023
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heyy @anujchoudhary-17 sorry for my late review, I was busy the last few days. The changes look good. Thanks a lot 😄

Only our automated testing is not happy with the formatting. Could you run dart format . to fix it.
(Its in line 155 it will split the ),), into two lines) 😅

@anujchoudhary-17
Copy link
Contributor Author

Heyy @anujchoudhary-17 sorry for my late review, I was busy the last few days. The changes look good. Thanks a lot 😄

Only our automated testing is not happy with the formatting. Could you run dart format . to fix it. (Its in line 155 it will split the ),), into two lines) 😅

Hi @M123-dev Sorry this is my first time contributing to Open Source. I have pulled and merged the code and ran that command and pushed it again. Is there anything else I am supposed to do?

@codecov-commenter
Copy link

Codecov Report

Merging #3940 (76516a9) into develop (cd04135) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3940      +/-   ##
===========================================
- Coverage    11.00%   10.99%   -0.01%     
===========================================
  Files          265      265              
  Lines        13044    13046       +2     
===========================================
  Hits          1435     1435              
- Misses       11609    11611       +2     
Impacted Files Coverage Δ
...ooth_app/lib/pages/user_management/login_page.dart 48.52% <0.00%> (-0.59%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anujchoudhary-17 that is everything needed already. Surprised that it went that well on your first contribution. I was quite confused on my first Pull request 🤣

Yeah, thanks a lot and not only congrats on your first contribution here but first overall 🥳

@M123-dev M123-dev merged commit 7d26df6 into openfoodfacts:develop May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
colors 👥 User management Account login, signup, signout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants