Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to flutter 3.10? #3953

Closed
monsieurtanuki opened this issue May 11, 2023 · 5 comments · Fixed by #4142
Closed

Upgrade to flutter 3.10? #3953

monsieurtanuki opened this issue May 11, 2023 · 5 comments · Fixed by #4142
Assignees
Labels
dependencies ✨ enhancement New feature or request

Comments

@monsieurtanuki
Copy link
Contributor

monsieurtanuki commented May 11, 2023

Problem

As usual, when flutter upgrades, it would not be a good idea to upgrade immediately on our developer computers.
But when should we upgrade?

Icing on the cake: "github" apparently did upgrade to 3.10, while our code is in 3.7.

https://medium.com/flutter/whats-new-in-flutter-3-10-b21db2c38c73

  • Material 3: Developers must “opt in” to these changes using the useMaterial3 theme flag. In the next stable release, useMaterial3 defaults to true.
  • ColorScheme.fromImageProvider()
  • SearchBar and SearchAnchor
  • Adaptive checkbox and radio ("The Material checkbox and radio widgets added the .adaptive constructors.")
  • Android CameraX support (camera: ^0.10.4, camera_android_camerax: ^0.5.0)
@g123k
Copy link
Collaborator

g123k commented Jun 12, 2023

Is-there something blocking to migrate to Flutter 3.10 / Dart 3?
It would fix this issue, that I'm waiting for months: #3806

@monsieurtanuki
Copy link
Contributor Author

@g123k We just didn't want to rush. No explicit blocking issue related to 3.10 AFAIK.
As you're without any doubt the best informed about the pending bugs of the latest flutter version, feel free to upgrade flutter if it's reasonably safe.

@g123k
Copy link
Collaborator

g123k commented Jun 13, 2023

@g123k We just didn't want to rush. No explicit blocking issue related to 3.10 AFAIK. As you're without any doubt the best informed about the pending bugs of the latest flutter version, feel free to upgrade flutter if it's reasonably safe.

Ok, I will wait for your PR #4131 to be merged and then implement it.
(There will be many files changed due to the removal of all break in switch)

@monsieurtanuki
Copy link
Contributor Author

monsieurtanuki commented Jun 13, 2023

Ok, I will wait for your PR #4131 to be merged and then implement it.

Thank you @g123k!
That removal of break in switch is one of the most stupid decisions I have ever seen, but C'est la vie !

@g123k g123k self-assigned this Jun 14, 2023
@g123k g123k linked a pull request Jun 14, 2023 that will close this issue
@g123k
Copy link
Collaborator

g123k commented Jun 14, 2023

Here is the list of unsupported Lint rules:

  • implicit-casts
  • implicit-dynamic

I will remove them (as it's mandatory).
Would you like to add/remove other rules?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ✨ enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

3 participants