Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTTP Library #735

Closed
Maxmontgelas opened this issue May 24, 2023 · 7 comments · Fixed by #770
Closed

Update HTTP Library #735

Maxmontgelas opened this issue May 24, 2023 · 7 comments · Fixed by #770
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@Maxmontgelas
Copy link

You need to update the http Library

@teolemon teolemon added the dependencies Pull requests that update a dependency file label May 26, 2023
@monsieurtanuki
Copy link
Contributor

@Maxmontgelas We don't need to upgrade the http library.
We're currently using http: ^0.13.5, and a new version of http (1.0.0) was released last week, with that change log:

  • Requires Dart 3.0 or later.
  • Add base, final, and interface modifiers to some classes.

Doesn't look like a massive improvement, and the main flutter project of openfoodfacts (https://github.com/openfoodfacts/smooth-app/) hasn't upgraded to flutter 3.10 / dart 3.0 yet (cf. openfoodfacts/smooth-app#3953)

@Maxmontgelas
Copy link
Author

Of course you should be upgrading keeping all up to date. What a strange reply.

@M123-dev
Copy link
Member

M123-dev commented Jun 6, 2023

Ok, we don't need to, but eventually we will. As monsieurtanuki pointed out, the main app for which this package is developed (https://github.com/openfoodfacts/smooth-app) isn't upgraded to flutter 3.7 just now so we'll have to postphone that.

Now the question is, what is stopping you (the intention behind this issue) @Maxmontgelas.

  1. Do you need a feature of http 1.0.0 if so you'll likely have to use a fork of this package for now
  2. Do you have some package conflicts, if so you can likely solve them using package overrides

@Maxmontgelas
Copy link
Author

Maxmontgelas commented Jun 7, 2023

It all works fine for myself as I've made appropriate adjustments. But one should not need to do adjustments as it's not so complicated or time consuming to update this here. Or the app that this is intended for. I update apps almost daily.

@marcelweigle
Copy link

The main reason to upgrade the HTTP dependency is that multiple other librarys depend on HTTP and therefor we can not upgrade our other dependencies. In my case i cannot upgrade google_fonts and typesense.

So this is kinda important and would be appreciated

@Maxmontgelas
Copy link
Author

Maxmontgelas commented Aug 2, 2023 via email

@monsieurtanuki
Copy link
Contributor

Will be taken care of in #764.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging a pull request may close this issue.

5 participants