Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New list picker scan session broken, when empty #4301

Closed
M123-dev opened this issue Jul 14, 2023 · 3 comments · Fixed by #4321
Closed

New list picker scan session broken, when empty #4301

M123-dev opened this issue Jul 14, 2023 · 3 comments · Fixed by #4321
Assignees
@monsieurtanuki
Labels
🐛 bug Something isn't working

Comments

@M123-dev
Copy link
Member

What

  • If the list is empty you can't switch away, the button is not visible

  • If you scan a product the list is not refreshed (after a restart it is)
@M123-dev M123-dev added the 🐛 bug Something isn't working label Jul 14, 2023
@monsieurtanuki monsieurtanuki self-assigned this Jul 14, 2023
@monsieurtanuki
Copy link
Contributor

@M123-dev Thanks for the bug detection!
Working on both bugs...

@monsieurtanuki monsieurtanuki mentioned this issue Jul 14, 2023
Merged
@g123k
Copy link
Collaborator

g123k commented Jul 14, 2023

@monsieurtanuki Since the PR is merged, is-it ok now for this issue?

@monsieurtanuki
Copy link
Contributor

@g123k No it's not: I still have to fix the more problematic bug (no systematic refresh).
I'll code that today or tomorrow, I've already imagined the solution.

The "invisible button" bug is fixed, though.

@monsieurtanuki monsieurtanuki mentioned this issue Jul 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
🐛 bug Something isn't working
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 4301 - new "up-to-date" provider for product list monsieurtanuki/smooth-app
3 participants
@g123k @monsieurtanuki @M123-dev