fix: 4301 - new "up-to-date" provider for product list #4321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `up_to_date_interest.dart`: Management of the interest for a key. * `up_to_date_product_list_mixin.dart`: Provides the most up-to-date local product list data for a StatefulWidget. * `up_to_date_product_list_provider.dart`: Provider that reflects the latest barcode lists on ProductLists. Impacted files: * `dao_product_list.dart`: made public method `getKey`; refreshes the provider * `local_database.dart`: added a new `UpToDateProductListProvider` * `product_list_page.dart`: now extends `UpToDateProductListMixin * `up_to_date_product_provider.dart`: refactored using a `UpToDateInterest` * `user_preferences_account.dart`: removed redundant access to product list page
Codecov Report
@@ Coverage Diff @@
## develop #4321 +/- ##
===========================================
- Coverage 10.80% 10.54% -0.26%
===========================================
Files 287 290 +3
Lines 14202 14251 +49
===========================================
- Hits 1534 1503 -31
- Misses 12668 12748 +80
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
You can test this PR on: https://app.waldo.com/applications/app-19d476740ba1bb36/sessions |
|
Thank you @g123k for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes bug(s)
Files
New files:
up_to_date_interest.dart: Management of the interest for a key.up_to_date_product_list_mixin.dart: Provides the most up-to-date local product list data for a StatefulWidget.up_to_date_product_list_provider.dart: Provider that reflects the latest barcode lists on ProductLists.Impacted files:
dao_product_list.dart: made public methodgetKey; refreshes the providerlocal_database.dart: added a newUpToDateProductListProviderproduct_list_page.dart: now extends `UpToDateProductListMixinup_to_date_product_provider.dart: refactored using aUpToDateInterestuser_preferences_account.dart: removed redundant access to product list page