-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 5301 - added an erasing tool for proofs #5341
Merged
monsieurtanuki
merged 2 commits into
openfoodfacts:develop
from
monsieurtanuki:feat_2/5301
Jun 7, 2024
Merged
feat: 5301 - added an erasing tool for proofs #5341
monsieurtanuki
merged 2 commits into
openfoodfacts:develop
from
monsieurtanuki:feat_2/5301
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `eraser_model.dart`: Model about the eraser tool: coordinate computations. * `eraser_painter.dart`: Painter of the eraser tool: displaying thick lines. Impacted files: * `background_task_add_price.dart`: displaying the eraser bars if relevant; new `eraserCoordinates` field * `background_task_image.dart`: minor refactoring * `crop_helper.dart`: new `enableEraser` field `offsets` parameters * `crop_page.dart`: added an erasing tool for proofs; refactored * `crop_parameters.dart`: new `eraserCoordinates` parameter * `operation_type.dart` unrelated minor refactoring * `product_crop_helper.dart`: minor refactoring * `product_price_item.dart`: unrelated fix for TEST env * `proof_crop_helper.dart`: minor refactoring * `pubspec.lock`: wtf * `pubspec.yaml`: needed upgrade of `crop_image` to `1.0.13`
github-actions
bot
added
dependencies
🖼️ Photos - Cropping
Prices
🔁 Background tasks
labels
Jun 6, 2024
teolemon
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we also need #5318 to be on the safe side of things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshots
CropImage
getCroppedBitmap
Uploaded image: https://prices.openfoodfacts.net/img/0003/pRFjLvNol8.jpg
Part of
Files
New files:
eraser_model.dart
: Model about the eraser tool: coordinate computations.eraser_painter.dart
: Painter of the eraser tool: displaying thick lines.Impacted files:
background_task_add_price.dart
: displaying the eraser bars if relevant; neweraserCoordinates
fieldbackground_task_image.dart
: minor refactoringcrop_helper.dart
: newenableEraser
fieldoffsets
parameterscrop_page.dart
: added an erasing tool for proofs; refactoredcrop_parameters.dart
: neweraserCoordinates
parameteroperation_type.dart
unrelated minor refactoringproduct_crop_helper.dart
: minor refactoringproduct_price_item.dart
: unrelated fix for TEST envproof_crop_helper.dart
: minor refactoringpubspec.lock
: wtfpubspec.yaml
: needed upgrade ofcrop_image
to1.0.13