Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove a maximum of hardcoded sizes and move Padding to Directional ones #2534

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jul 7, 2022

Move all EdgeInsets to EdgeInsetsDirectional (to better support RTL)

  • replace all default sizes with constants

@g123k g123k requested a review from a team as a code owner July 7, 2022 16:32
@g123k g123k self-assigned this Jul 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #2534 (99b56e2) into develop (2ea0da3) will decrease coverage by 1.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2534      +/-   ##
==========================================
- Coverage     8.86%   7.57%   -1.30%     
==========================================
  Files          161     210      +49     
  Lines         6623   10077    +3454     
==========================================
+ Hits           587     763     +176     
- Misses        6036    9314    +3278     
Impacted Files Coverage Δ
...kages/smooth_app/lib/widgets/attribute_button.dart 0.00% <0.00%> (-92.00%) ⬇️
...s/smooth_app/lib/data_models/user_preferences.dart 8.73% <0.00%> (-23.57%) ⬇️
packages/smooth_app/lib/themes/smooth_theme.dart 60.00% <0.00%> (-22.98%) ⬇️
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 15.11% <0.00%> (-19.10%) ⬇️
...mooth_app/lib/data_models/product_preferences.dart 24.65% <0.00%> (-6.78%) ⬇️
packages/smooth_app/lib/main.dart 14.16% <0.00%> (-3.73%) ⬇️
.../smooth_app/lib/pages/onboarding/welcome_page.dart 0.00% <0.00%> (-3.13%) ⬇️
.../smooth_app/lib/pages/onboarding/scan_example.dart 0.00% <0.00%> (-2.28%) ⬇️
...p/lib/pages/onboarding/consent_analytics_page.dart 0.00% <0.00%> (-1.57%) ⬇️
...smooth_app/lib/pages/product/new_product_page.dart 0.00% <0.00%> (-0.88%) ⬇️
... and 221 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2065bca...99b56e2. Read the comment docs.

@teolemon teolemon added the RTL Working well in right to left languages like Arabic or Hebrew label Jul 8, 2022
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @g123k

@teolemon teolemon merged commit 9ebe5c8 into openfoodfacts:develop Jul 13, 2022
@teolemon
Copy link
Member

Thanks @g123k and thanks @M123-dev for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RTL Working well in right to left languages like Arabic or Hebrew
Development

Successfully merging this pull request may close these issues.

4 participants