fix: #2009 - product page will always pull down - and refresh #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fresh For the record, tested on `3489940014075` on server `world.openbeautyfacts.org`. I've also written the explanation behind the trick - perhaps that would make sense to create a wiki about nice tricks: ```dart // /!\ Smart Dart // `physics: const AlwaysScrollableScrollPhysics()` // means that we will always scroll, even if it's pointless. // Why do we need to? For the RefreshIndicator, that wouldn't be // triggered on a ListView smaller than the screen // (as there will be no scroll). ``` Impacted file: `new_product_page.dart`: forced the page content to scroll even when not necessary
M123-dev
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Great solution and even better comment, thanks @monsieurtanuki
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the record, tested on
3489940014075on serverworld.openbeautyfacts.org.I've also written the explanation behind the trick - perhaps that would make sense to create a wiki about nice tricks:
Impacted file:
new_product_page.dart: forced the page content to scroll even when not necessaryWhat
Fixes bug(s)