Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Finalize new pipeline #2824

Merged
merged 1 commit into from
Aug 21, 2022
Merged

ci: Finalize new pipeline #2824

merged 1 commit into from
Aug 21, 2022

Conversation

M123-dev
Copy link
Member

@M123-dev M123-dev commented Aug 21, 2022

What

Related to

#2811
#2812
#2813
#2814
#2816
#2817
#2818
#2819
#2820
#2821
#2822
#2823
#2771
#2286
#1882

@M123-dev M123-dev requested a review from teolemon August 21, 2022 12:12
@M123-dev M123-dev requested a review from a team as a code owner August 21, 2022 12:12
@teolemon teolemon changed the title ci: Finalize new pipline ci: Finalize new pipeline Aug 21, 2022
# SIGN_KEY_ALIAS: ${{ secrets.SIGN_KEY_ALIAS }}
# SIGN_KEY_PASSWORD: ${{ secrets.SIGN_KEY_PASSWORD }}

- name: Release AAB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had it been disabled by the previous work you had merged ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I've disabled it so that for example android works but not iOS I don't submit lots of dublicate builds

- name: Release AAB
uses: maierj/fastlane-action@v2.2.1
with:
lane: closed_beta
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is fastlane actually sending to closed_beta ? or internal ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal

@M123-dev M123-dev merged commit cbe7677 into develop Aug 21, 2022
@M123-dev M123-dev deleted the ci-final-activation branch August 21, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants