fix: #2841 - from "AddNewProductPage", no need to be logged in to add data #2844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ged in to add data Impacted files: * `add_basic_details_page.dart`: added parameter `bool isLoggedInMandatory` * `add_new_product_page.dart`: explicitly calls both pages `AddBasicDetailsPage` and `NutritionPageLoaded` with `isLoggedInMandatory: false` * `nutrition_page_loaded.dart`: added parameter `bool isLoggedInMandatory`
|
teolemon
added
the
Product addition
teolemon
approved these changes
Aug 26, 2022
|
@teolemon Thank you for your review! |
|
Analyze and test |
|
I believe the culprit is cc @M123-dev |
|
@monsieurtanuki I believe this is related to working on a fork, it would work on a push to a branch, I believe |
|
@teolemon Maybe you're right, but I pushed this code the same way as my other PRs. |
|
Thank you guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
add_basic_details_page.dart: added parameterbool isLoggedInMandatoryadd_new_product_page.dart: explicitly calls both pagesAddBasicDetailsPageandNutritionPageLoadedwithisLoggedInMandatory: falsenutrition_page_loaded.dart: added parameterbool isLoggedInMandatoryWhat
saveAndRefreshmethod has abool isLoggedInMandatoryparameter.true, and actually we always used the default value: each time we used this method we checked first if the user was logged in. Which was not the desired behavior when creating a new product.falsein (only) 2 cases: insideAddNewProductPage, forAddBasicDetailsPageandNutritionPageLoadedFixes bug(s)