Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: back to flutter 3.0.5 #2923

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Reverted the upgrade to flutter 3.0.5

Part of

@monsieurtanuki
Copy link
Contributor Author

Thank you @g123k!
@M123-dev Now we need the CI to downgrade to flutter 3.0.5 if we want the tests to pass.

@M123-dev
Copy link
Member

M123-dev commented Sep 6, 2022

Heyy @monsieurtanuki I took the liberty to just commit the CI & CD fixes to this PR, I hope this isn't a problem.

+ I added a disclaimer to the README

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #2923 (84a0051) into develop (d9c35d7) will increase coverage by 0.17%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #2923      +/-   ##
==========================================
+ Coverage     6.71%   6.88%   +0.17%     
==========================================
  Files          228     229       +1     
  Lines        11117   11138      +21     
==========================================
+ Hits           746     767      +21     
  Misses       10371   10371              
Impacted Files Coverage Δ
...h_app/lib/cache/files/file_cache_manager_impl.dart 94.59% <ø> (ø)
...pp/lib/pages/onboarding/onboarding_bottom_bar.dart 0.00% <0.00%> (ø)
...h_app/lib/pages/product/edit_ingredients_page.dart 0.00% <ø> (ø)
...smooth_app/lib/pages/product/new_product_page.dart 0.00% <0.00%> (ø)
...h_app/lib/pages/product/nutrition_page_loaded.dart 0.00% <ø> (ø)
...mooth_app/lib/pages/product/simple_input_page.dart 0.00% <0.00%> (ø)
...h_app/lib/pages/scan/camera_image_full_getter.dart 0.00% <ø> (ø)
...ib/generic_lib/dialogs/smooth_category_picker.dart 86.77% <0.00%> (-0.37%) ⬇️
packages/smooth_app/lib/database/dao_int.dart 0.00% <0.00%> (ø)
packages/smooth_app/lib/database/dao_string.dart 0.00% <0.00%> (ø)
... and 38 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon
Copy link
Member

teolemon commented Sep 6, 2022

Thanks @M123-dev @monsieurtanuki @g123k

@teolemon teolemon merged commit 513af0e into openfoodfacts:develop Sep 6, 2022
@monsieurtanuki
Copy link
Contributor Author

Thank you @M123-dev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants