Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: harmonize search modals #3085

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

AshAman999
Copy link
Member

What

  • harmonized the views
  • couldn't refactor as the views don't update automatically maybe something related to stateful builders, but things didn't help
  • probably would do more detail work/ refactoring, once I am totally free from my exams 😕

Screenshot

image

image

image

Fixes bug(s)

Part of

@AshAman999 AshAman999 requested a review from a team as a code owner October 3, 2022 14:00
@AshAman999 AshAman999 requested a review from M123-dev October 3, 2022 14:01
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2022

Codecov Report

Merging #3085 (7f9fc1c) into develop (65d4122) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           develop   #3085   +/-   ##
=======================================
  Coverage     6.47%   6.47%           
=======================================
  Files          246     246           
  Lines        12184   12183    -1     
=======================================
  Hits           789     789           
+ Misses       11395   11394    -1     
Impacted Files Coverage Δ
...app/lib/generic_lib/widgets/language_selector.dart 0.00% <0.00%> (ø)
...h_app/lib/pages/product/nutrition_page_loaded.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@VaiTon VaiTon changed the title fix: make harmonized search models fix: harmonize search modals Oct 3, 2022
@teolemon teolemon added the modals label Oct 3, 2022
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @AshAman999

@M123-dev M123-dev merged commit f277e3e into openfoodfacts:develop Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harmonize the search modals
4 participants