Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improvement for adding a product to lists #3126

Merged
merged 2 commits into from
Oct 13, 2022
Merged

feat: Improvement for adding a product to lists #3126

merged 2 commits into from
Oct 13, 2022

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Oct 11, 2022 •
edited by teolemon
Loading

What

  • This PR changes the "Add a product to a list" dialog:
  • When there is no list, it is clearly explained that a list should be created
  • When at least one list is available, a Save button is now displayed to force the user to validate its choice

Video

In video, this should be better understandable:

list.mp4

@g123k g123k requested a review from a team as a code owner October 11, 2022 14:11
@g123k g123k self-assigned this Oct 11, 2022
@teolemon
Copy link
Member

We used to solve this by pre-creating a few lists in the old app (Product I ate, Shopping list)

@teolemon teolemon merged commit 1700322 into openfoodfacts:develop Oct 13, 2022
@github-actions github-actions bot mentioned this pull request Oct 13, 2022
Merged
@g123k g123k deleted the product_add_to_list branch October 24, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@g123k g123k

Labels
lists 🥫 Product page User lists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g123k @teolemon