Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backbutton now visible issue #3133 #3170

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

Akashsri3bi
Copy link
Contributor

Screenshot_2022-10-13-19-23-53-29 1

@Akashsri3bi Akashsri3bi requested a review from a team as a code owner October 17, 2022 18:13
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Akashsri3bi the code looks good to me. Hopefully we did not miss a Page where it's now different but I don't think so. 🎉

@Akashsri3bi
Copy link
Contributor Author

Thanks @Akashsri3bi the code looks good to me. Hopefully we did not miss a Page where it's now different but I don't think so. 🎉

Thanks !

@g123k g123k linked an issue Oct 22, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #3170 (0026b6b) into develop (adb7716) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #3170      +/-   ##
==========================================
- Coverage     6.19%   6.17%   -0.02%     
==========================================
  Files          248     252       +4     
  Lines        12439   12492      +53     
==========================================
+ Hits           771     772       +1     
- Misses       11668   11720      +52     
Impacted Files Coverage Δ
...pp/lib/generic_lib/widgets/smooth_back_button.dart 6.66% <0.00%> (-0.48%) ⬇️
...th_app/lib/pages/product/product_image_viewer.dart 0.00% <ø> (ø)
...pages/preferences/user_preferences_contribute.dart 4.72% <0.00%> (-0.14%) ⬇️
...ges/smooth_app/lib/pages/product/summary_card.dart 0.00% <0.00%> (ø)
...mooth_app/lib/helpers/robotoff_insight_helper.dart 0.00% <0.00%> (ø)
...th_app/lib/cards/data_cards/image_upload_card.dart 0.00% <0.00%> (ø)
...ib/cards/product_cards/product_image_carousel.dart 0.00% <0.00%> (ø)
...b/pages/preferences/user_preferences_dev_mode.dart 0.00% <0.00%> (ø)
packages/smooth_app/lib/pages/question_page.dart
...smooth_app/lib/query/robotoff_questions_query.dart
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@M123-dev M123-dev merged commit d43c02b into openfoodfacts:develop Oct 22, 2022
@M123-dev
Copy link
Member

Congrats on your first PR here @Akashsri3bi 🥳

@Akashsri3bi
Copy link
Contributor Author

Congrats on your first PR here @Akashsri3bi 🥳

Thanks very much @M123-dev many more contributions to come !

@Akashsri3bi Akashsri3bi deleted the ak1 branch October 26, 2022 15:21
@M123-dev M123-dev added this to the v4 milestone Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BackButton Not visible in light mode
3 participants