feat: 3129 (New PR) Allow to swipe between product images on the full screen image

[omkarChend1kar]

What

• Allow to swipe between product images on the full screen image view #3129

Screenshot/Mockups after :

swiping.mp4

Part of

• Improve the Photo Manager using new features from openfoodfacts-dart #766

[monsieurtanuki]

Hi @omkarChend1kar!
Please fix the warnings first:

info • Unused import: 'package:smooth_app/generic_lib/design_constants.dart' • packages/smooth_app/lib/pages/product/product_image_viewer.dart:15:8 • unused_import

info • Unused import: 'package:smooth_app/generic_lib/widgets/smooth_back_button.dart' • packages/smooth_app/lib/pages/product/product_image_viewer.dart:18:8 • unused_import

warning • The left operand can't be null, so the right operand is never executed • packages/smooth_app/lib/pages/product/product_image_viewer.dart:105:27 • dead_null_aware_expression

[omkarChend1kar]

Hi @omkarChend1kar! Please fix the warnings first:

info • Unused import: 'package:smooth_app/generic_lib/design_constants.dart' • packages/smooth_app/lib/pages/product/product_image_viewer.dart:15:8 • unused_import

info • Unused import: 'package:smooth_app/generic_lib/widgets/smooth_back_button.dart' • packages/smooth_app/lib/pages/product/product_image_viewer.dart:18:8 • unused_import

warning • The left operand can't be null, so the right operand is never executed • packages/smooth_app/lib/pages/product/product_image_viewer.dart:105:27 • dead_null_aware_expression

Yes, On it.

[codecov-commenter]

Codecov Report

Merging #3363 (a8c2e08) into develop (2621b3a) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3363      +/-   ##
===========================================
- Coverage    10.47%   10.43%   -0.04%     
===========================================
  Files          255      256       +1     
  Lines        12421    12463      +42     
===========================================
  Hits          1301     1301              
- Misses       11120    11162      +42     

Impacted Files	Coverage Δ
..._lib/widgets/images/smooth_images_sliver_list.dart	0.00% <0.00%> (ø)
...generic_lib/widgets/images/smooth_images_view.dart	0.00% <ø> (ø)
.../lib/pages/product/product_image_gallery_view.dart	0.00% <0.00%> (ø)
...ib/pages/product/product_image_swipeable_view.dart	0.00% <0.00%> (ø)
...th_app/lib/pages/product/product_image_viewer.dart	0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[monsieurtanuki]

Looks good @omkarChend1kar!

Again, the use of ValueNotifier instead of setState is a quite unexpected, so do add a comment explaining that you use it for performance reasons.

And then we're ok (except maybe for initialProductImageCategoryIndex that could be shortened to initialImageIndex, but that's a detail).

[monsieurtanuki]

That's great, thank you @omkarChend1kar!

[monsieurtanuki]

Except for the format. Please have a look at it again.

[omkarChend1kar]

Except for the format. Please have a look at it again.

Yeah

[omkarChend1kar]

That's great, thank you @omkarChend1kar!

Yeah. Thanks for being supportive @monsieurtanuki!