refactor: upgrade to off-dart 2.0.0 #3495
Merged
+145
−211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `paged_to_be_completed_product_query.dart`: renamed `State` as `ProductState` * `paged_user_product_query.dart`: created local `UserSearchType` instead of deprecated off-dart `UserProductSearchType`; used `ProductSearchQueryConfiguration` instead of deprecated `UserProductSearchQueryConfiguration` * `pubspec.lock`: wtf * `pubspec.yaml`: upgrade to off-dart 2.0.0 * `user_preferences_account.dart`: now using new local class `UserSearchType` * and reduced all off-dart imports to a single `import 'package:openfoodfacts/openfoodfacts.dart';`
github-actions
bot
added
📈 Analytics
Codecov Report
@@ Coverage Diff @@
## develop #3495 +/- ##
===========================================
+ Coverage 11.09% 11.16% +0.07%
===========================================
Files 262 262
Lines 12831 12840 +9
===========================================
+ Hits 1424 1434 +10
+ Misses 11407 11406 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Impacted file: * `paged_user_product_query.dart`: fixed bug - now `toBeCompleted` filter is not systematic
Impacted file: * `paged_user_product_query.dart`: now explicitly using the same version as the rest of the app
Impacted file: * `paged_user_product_query.dart`: now using the "normal" fields * `product_query.dart`: now that we use fully v3, we don't need the temporary field list for user-related queries with v2
|
Thank you @AshAman999 for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
paged_to_be_completed_product_query.dart: renamedStateasProductStatepaged_user_product_query.dart: created localUserSearchTypeinstead of deprecated off-dartUserProductSearchType; usedProductSearchQueryConfigurationinstead of deprecatedUserProductSearchQueryConfigurationpubspec.lock: wtfpubspec.yaml: upgrade to off-dart 2.0.0user_preferences_account.dart: now using new local classUserSearchTypeimport 'package:openfoodfacts/openfoodfacts.dart';What
Part of