fix: 3490 - now accepting not cropped new pictures #3524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `image_crop_page.dart`: told the `CropPage` we're dealing with a brand new picture * `new_crop_page.dart`: new `bool` parameter `brandNewPicture` used when saving the picture; refactored the debug lines * `product_image_viewer.dart`: told the `CropPage` we're dealing with an already existing picture
Codecov Report
@@ Coverage Diff @@
## develop #3524 +/- ##
===========================================
+ Coverage 11.05% 11.07% +0.01%
===========================================
Files 262 262
Lines 12978 12955 -23
===========================================
Hits 1435 1435
+ Misses 11543 11520 -23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
teolemon
approved these changes
Jan 5, 2023
|
I had no way to test but that should be good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
image_crop_page.dart: told theCropPagewe're dealing with a brand new picturenew_crop_page.dart: newboolparameterbrandNewPictureused when saving the picture; refactored the debug linesproduct_image_viewer.dart: told theCropPagewe're dealing with an already existing pictureWhat
Fixes bug(s)