feat: 2484 - now when editing we go to the full image with the cropped area on top #3658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d area on top Impacted files: * `app_en.arb`: added a label for the "send image" button (instead of vague "confirm") * `background_task_crop.dart`: added a product change where we store the crop parameters * `background_task_image.dart`: added a fake product change where we remove the crop parameters * `new_crop_page.dart`: added constructor parameters `initialCropRect` and `initialRotation`; removed the "new photo" button for UI/UX consistency * `product_image_viewer.dart`: refactored with 2 or 4 buttons and cleaner code * `product_query.dart`: added `IMAGES` product field * `pubspec.lock`: wtf * `pubspec.yaml`: upgraded `openfoodfacts` to `2.2.1` (about `ProductImage`) * `rotation.dart`: added method `fromDegrees` * `up_to_date_changes.dart`: added `images` to "overwritable" product fields; now accepts all operation types
Codecov Report
@@ Coverage Diff @@
## develop #3658 +/- ##
===========================================
- Coverage 10.65% 10.56% -0.09%
===========================================
Files 270 270
Lines 13474 13584 +110
===========================================
Hits 1435 1435
- Misses 12039 12149 +110
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you @teolemon for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
app_en.arb: added a label for the "send image" button (instead of vague "confirm")background_task_crop.dart: added a product change where we store the crop parametersbackground_task_image.dart: added a fake product change where we remove the crop parametersnew_crop_page.dart: added constructor parametersinitialCropRectandinitialRotation; removed the "new photo" button for UI/UX consistencyproduct_image_viewer.dart: refactored with 2 or 4 buttons and cleaner codeproduct_query.dart: addedIMAGESproduct fieldpubspec.lock: wtfpubspec.yaml: upgradedopenfoodfactsto2.2.1(aboutProductImage)rotation.dart: added methodfromDegreesup_to_date_changes.dart: addedimagesto "overwritable" product fields; now accepts all operation typesWhat
Screenshot
Read-only page with no previous image:
Fixes bug(s)
Part of