Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Incorrect theme used for the AppBar title on the Product Edition page #3805

Merged
merged 1 commit into from
Mar 27, 2023
Merged

fix: Incorrect theme used for the AppBar title on the Product Edition page #3805

merged 1 commit into from
Mar 27, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Mar 25, 2023

To follow this issue #3804, the wrong theme is used on the Product Edition Page.
Instead of the textTheme, the primaryTextTheme is used in this screen.

The primaryTextTheme has a white color, so white on white gives this behavior.

Before:
Simulator Screen Shot - iPhone 14 Pro Max - 2023-03-25 at 09 09 53

After:
Simulator Screen Shot - iPhone 14 Pro Max - 2023-03-25 at 09 19 01

@g123k g123k added 🍎 iOS iOS specific issues or PRs 🥫 Product page labels Mar 25, 2023
@g123k g123k requested a review from a team as a code owner March 25, 2023 08:31
@g123k g123k self-assigned this Mar 25, 2023
@g123k g123k linked an issue Mar 25, 2023 that may be closed by this pull request
On iOS, the AppBar title is invisible #3804
Closed
@codecov-commenter
Copy link

Codecov Report

Merging #3805 (34a6b6c) into develop (9d2db67) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #3805   +/-   ##
========================================
  Coverage    10.67%   10.67%           
========================================
  Files          272      272           
  Lines        13547    13546    -1     
========================================
  Hits          1446     1446           
+ Misses       12101    12100    -1
Impacted Files Coverage Δ
...mooth_app/lib/pages/product/edit_product_page.dart 0.45% <0.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AshAman999 AshAman999 changed the title Incorrect theme used for the AppBar title on the Product Edition page fix: Incorrect theme used for the AppBar title on the Product Edition page Mar 25, 2023
@teolemon
Copy link
Member

thanks @g123k @AshAman999 👍

M123-dev
M123-dev approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The barcode should be visible for shorter names, right?

@M123-dev M123-dev merged commit 475d228 into openfoodfacts:develop Mar 27, 2023
@github-actions github-actions bot mentioned this pull request Mar 27, 2023
Merged
@g123k
Copy link
Collaborator Author

g123k commented Mar 28, 2023

The barcode should be visible for shorter names, right?

Yes that's correct, we should open an issue for this one (really easy to fix

@M123-dev M123-dev mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshAman999 AshAman999 AshAman999 approved these changes

@M123-dev M123-dev M123-dev approved these changes

Assignees

@g123k g123k

Labels
🍎 iOS iOS specific issues or PRs 🥫 Product page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On iOS, the AppBar title is invisible
5 participants
@g123k @codecov-commenter @teolemon @M123-dev @AshAman999