chore: upgrade - flutter_svg, camera #3945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `analytics_helper.dart`: minor refactoring with new matomo version * `edit_product_page.dart`: minor refactoring with new svg version * `pubspec.lock`: wtf * `scanner/pubspec.yaml`: new svg version * `smooth_app/pubspec.yaml`: new svg, camera and matomo versions * `smooth_product_card_thanks.dart`: minor refactoring with new svg version * `svg_async_asset.dart`: minor refactoring with new svg version * `svg_cache.dart`: minor refactoring with new svg version * `user_preferences_settings.dart`: minor refactoring with new matomo version
github-actions
bot
added
📈 Analytics
|
Unrelated failures |
teolemon
approved these changes
May 8, 2023
They seem related actually, if you expand the errors - something like "matomo not initialized". |
teolemon
requested changes
May 9, 2023
github-actions
bot
removed
the
📈 Analytics
monsieurtanuki
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #3945 +/- ##
===========================================
- Coverage 11.00% 10.99% -0.01%
===========================================
Files 265 265
Lines 13042 13046 +4
===========================================
Hits 1435 1435
- Misses 11607 11611 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Somehow automerge won't work as long as @teolemon is requesting changes |
teolemon
approved these changes
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
flutter_svgand(minor breaking changes) andmatomo_trackercamera(no breaking changes)Impacted files
analytics_helper.dart: minor refactoring with new matomo versionedit_product_page.dart: minor refactoring with new svg versionpubspec.lock: wtfscanner/pubspec.yaml: new svg versionsmooth_app/pubspec.yaml: new svg, cameraand matomoversionssmooth_product_card_thanks.dart: minor refactoring with new svg versionsvg_async_asset.dart: minor refactoring with new svg versionsvg_cache.dart: minor refactoring with new svg versionuser_preferences_settings.dart: minor refactoring with new matomo version