Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve the website card #4002

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented May 23, 2023

Hi everyone,

Initially, I wanted to fix the ripple on the website card… and after all I have also added the icon on the right (from #3819)

Before:
https://github.com/openfoodfacts/smooth-app/assets/246838/61a8c569-df2c-4f37-8084-baa331bdb0a4

After:
https://github.com/openfoodfacts/smooth-app/assets/246838/3ad82c64-905e-4e9e-851f-38cb546f4258

@g123k g123k requested a review from a team as a code owner May 23, 2023 10:36
@g123k g123k self-assigned this May 23, 2023
@g123k g123k linked an issue May 23, 2023 that may be closed by this pull request
@github-actions github-actions bot added the Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. label May 23, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4002 (2b9e39f) into develop (76762b1) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4002      +/-   ##
===========================================
- Coverage    10.96%   10.95%   -0.02%     
===========================================
  Files          265      266       +1     
  Lines        13090    13105      +15     
===========================================
  Hits          1435     1435              
- Misses       11655    11670      +15     
Impacted Files Coverage Δ
...smooth_app/lib/pages/product/new_product_page.dart 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teolemon teolemon merged commit c1b1211 into openfoodfacts:develop May 25, 2023
@g123k g123k deleted the product_website branch May 26, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product page: the website card is not well integrated
3 participants