-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 4041 - renamed "history" bottom item as "lists", w/ access to other lists #4277
Conversation
…ss to other lists New file: * `product_list_popup_items.dart`: Popup menu items for the product list page. Impacted files: * `app_en.arb`: added 2 labels * `page_manager.dart`: new label and icon for bottom bar * `product_list_page.dart`: added fast access to scan session, scan history and history; moved code to `product_list_popup_items.dart` * `product_query_page_helper.dart`: minor refactoring * `scan_header.dart`: minor refactoring * `tab_navigator.dart`: minor refactoring * `user_preferences_account.dart`: minor refactoring
Codecov Report
@@ Coverage Diff @@
## develop #4277 +/- ##
===========================================
- Coverage 10.82% 10.80% -0.02%
===========================================
Files 286 287 +1
Lines 14247 14273 +26
===========================================
Hits 1542 1542
- Misses 12705 12731 +26
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi @monsieurtanuki! Thanks a lot for your PR. Generally speaking in terms of code, that looks OK. But after trying your implementation on a device, I'm not convinced about the UX. The menu is also confusing because we mix external actions (eg: Share / View on the web) and direct actions on the list. Here are my suggestions:
What do you think of this change? |
I would put the most important thing first, like
That's the general idea of a menu, and that's why they usually put separators.
Understood.
I don't believe in custom icons.
I don't want to overload the app bar with buttons (I have a small screen, remember). Btw the label is incorrect: we clear whatever list (not just history). To summarize:
@g123k What do you think of those improvements? |
I love the change. |
@g123k I've just pushed a code that should be OK for you.
|
Yes indeed, you're right, it's a bit awkward. I will think about a better solution. |
I've just removed the |
Thanks a lot for your work @monsieurtanuki |
Thank you @g123k for your review! |
What
Screenshots
Part of
Files
New file:
product_list_popup_items.dart
: Popup menu items for the product list page.Impacted files:
app_en.arb
: added 2 labelspage_manager.dart
: new label and icon for bottom barproduct_list_page.dart
: added fast access to scan session, scan history and history; moved code toproduct_list_popup_items.dart
product_query_page_helper.dart
: minor refactoringscan_header.dart
: minor refactoringtab_navigator.dart
: minor refactoringuser_preferences_account.dart
: minor refactoring