-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 5128 - visible dates on raw image grid items #5144
feat: 5128 - visible dates on raw image grid items #5144
Conversation
Impacted files: * `product_image_gallery_other_view.dart`: display the upload date on top of raw image grid items * `product_image_gallery_view.dart`: unrelated minor refactoring * `pubspec.lock`: wtf * `pubspec.yaml`: upgrade to off-dart 3.5.0 in order to get the uploaded timestamp of raw images * `smooth_image.dart`: unrelated minor refactoring
@jusdekiwi ping |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5144 +/- ##
==========================================
- Coverage 9.54% 9.52% -0.03%
==========================================
Files 325 327 +2
Lines 16411 16541 +130
==========================================
+ Hits 1567 1576 +9
- Misses 14844 14965 +121 ☔ View full report in Codecov by Sentry. |
Seems super great!! I love it :D @monsieurtanuki |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll probably have to rethink things for moderation but Looks good.
Thank you @teolemon @jusdekiwi for your review and comments! |
Thank you for you work @monsieurtanuki ! :D |
What
Screenshot
Part of
Impacted files
product_image_gallery_other_view.dart
: display the upload date on top of raw image grid itemsproduct_image_gallery_view.dart
: unrelated minor refactoringpubspec.lock
: wtfpubspec.yaml
: upgrade to off-dart 3.5.0 in order to get the uploaded timestamp of raw imagessmooth_image.dart
: unrelated minor refactoring