Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 5288 - added svg files to asset cache #5299

Merged
merged 1 commit into from
May 28, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Added svg files to asset cache
  • There will probably be more files given the naming of the files (e.g. points-negative-5-10.svg), but let's see first if we really need all of them (in case some ratings are never given).

Part of

@monsieurtanuki monsieurtanuki requested a review from a team as a code owner May 28, 2024 06:15
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.95%. Comparing base (4d9c7fc) to head (875ac09).
Report is 144 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5299      +/-   ##
==========================================
- Coverage     9.54%   7.95%   -1.60%     
==========================================
  Files          325     368      +43     
  Lines        16411   18526    +2115     
==========================================
- Hits          1567    1473      -94     
- Misses       14844   17053    +2209     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit dcd70ea into openfoodfacts:develop May 28, 2024
6 checks passed
@g123k g123k linked an issue May 28, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Missing SVGs in cache
3 participants