-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 5205 - new "my prices" page #5347
Merged
monsieurtanuki
merged 3 commits into
openfoodfacts:develop
from
monsieurtanuki:feat_3/5205
Jun 8, 2024
Merged
feat: 5205 - new "my prices" page #5347
monsieurtanuki
merged 3 commits into
openfoodfacts:develop
from
monsieurtanuki:feat_3/5205
Jun 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted files: * `product_price_item.dart` * `product_prices_page.dart` New files: * `get_prices_model.dart`: Model that stores what we need to know for "get latest prices" queries. * `price_button.dart`: Simple price button: displaying data with optional action. * `price_count_widget.dart`: Price Count display. * `price_data_widget.dart`: Price Data display (no product data here). * `price_product_widget.dart`: Price Product display (no price data here). * `prices_page.dart`: Page that displays the latest prices according to a model. Impacted files: * `labeler.yml`: deleted and new files * `prices_card.dart`: refactored using new classes * `product_prices_list.dart`: refactored using new classes * `user_preferences_account.dart`: refactored using new classes
teolemon
approved these changes
Jun 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshots
Fixes bug(s)
Files
Deleted files:
product_price_item.dart
product_prices_page.dart
New files:
get_prices_model.dart
: Model that stores what we need to know for "get latest prices" queries.price_button.dart
: Simple price button: displaying data with optional action.price_count_widget.dart
: Price Count display.price_data_widget.dart
: Price Data display (no product data here).price_product_widget.dart
: Price Product display (no price data here).prices_page.dart
: Page that displays the latest prices according to a model.Impacted files:
labeler.yml
: deleted and new filesprices_card.dart
: refactored using new classesproduct_prices_list.dart
: refactored using new classesuser_preferences_account.dart
: refactored using new classes