Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom domain + environment support for the TagLine #5364

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jun 13, 2024

Hi everyone!

The TagLine fetcher now supports custom domains + test/prod environments.
When one of the two is updated, the tagline is forced to be resynced with the new URL.

  • In the case where the JSON is invalid, an error is not sent to Sentry

@g123k g123k requested a review from a team as a code owner June 13, 2024 06:33
@github-actions github-actions bot added the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Jun 13, 2024
@g123k g123k changed the title feat: Support custom domain + env for the TagLine feat: Custom domain + environment support for the TagLine Jun 13, 2024
@g123k g123k added the tagline label Jun 13, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 7.44%. Comparing base (4d9c7fc) to head (41091de).
Report is 183 commits behind head on develop.

Files Patch % Lines
..._app/lib/data_models/tagline/tagline_provider.dart 0.00% 26 Missing ⚠️
packages/smooth_app/lib/pages/scan/scan_page.dart 0.00% 24 Missing ⚠️
packages/smooth_app/lib/main.dart 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5364      +/-   ##
==========================================
- Coverage     9.54%   7.44%   -2.11%     
==========================================
  Files          325     380      +55     
  Lines        16411   19454    +3043     
==========================================
- Hits          1567    1448     -119     
- Misses       14844   18006    +3162     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit 08071d2 into openfoodfacts:develop Jun 13, 2024
6 checks passed
@teolemon
Copy link
Member

thanks @g123k 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… tagline
Development

Successfully merging this pull request may close these issues.

3 participants