Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5594 - multi product scan mode as a dev mode option for price receipt input #6008

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Now there's a new switch in DEV MODE: "multi-products selection for prices"
  • When the switch is true (default is false), when we scan products for prices (e.g. new receipt page) we're able to scan several barcodes in a row, and tap on the floating action button to say "hey, I'm done"

Screenshots

dev mode switch 1 scanned product
Screenshot_20241205_174929 Screenshot_20241205_175303
2 scanned products receipt w/ 2 products
Screenshot_20241205_175437 Screenshot_20241205_175502

Fixes bug(s)

Impacted files

  • price_add_product_card.dart: now calling the scan card with the bool multi product scan mode parameter, and manages a list of scanned barcodes
  • price_scan_page.dart: now manages a multi product scan mode, with floating action button and snackbar
  • user_preferences_dev_mode.dart: new flag for "multi product scan in price receipt"

…eceipt input

Impacted files:
* `price_add_product_card.dart`: now calling the scan card with the bool multi product scan mode parameter, and manages a _list_ of scanned barcodes
* `price_scan_page.dart`: now manages a multi product scan mode, with floating action button and snackbar
* `user_preferences_dev_mode.dart`: new flag for "multi product scan in price receipt"
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 66 lines in your changes missing coverage. Please review.

Project coverage is 6.48%. Comparing base (4d9c7fc) to head (4ac5e85).
Report is 566 commits behind head on develop.

Files with missing lines Patch % Lines
...h_app/lib/pages/prices/price_add_product_card.dart 0.00% 35 Missing ⚠️
...s/smooth_app/lib/pages/prices/price_scan_page.dart 0.00% 25 Missing ⚠️
...b/pages/preferences/user_preferences_dev_mode.dart 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6008      +/-   ##
==========================================
- Coverage     9.54%   6.48%   -3.07%     
==========================================
  Files          325     441     +116     
  Lines        16411   25061    +8650     
==========================================
+ Hits          1567    1624      +57     
- Misses       14844   23437    +8593     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon
Copy link
Member

teolemon commented Dec 6, 2024

@monsieurtanuki @g123k this would be interesting to quickly populate user lists (eg a shopping list).

@monsieurtanuki
Copy link
Contributor Author

@monsieurtanuki @g123k this would be interesting to quickly populate user lists (eg a shopping list).

@teolemon That wouldn't be a problem as we already have the tool for that: a camera+scanner that calls an "I've just found that barcode!" method. In this PR the method populates a list of barcodes, pop'ed only when the user clicks on the FAB.

If you have a new idea for user lists, please create a specific issue.
And don't hesitate to review the current PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Status: 💬 To discuss and validate
Development

Successfully merging this pull request may close these issues.

Have an option for continous scanning when entering prices
3 participants