-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New paths for backend API #26
Conversation
in taxonomy parsing spec and in sample json for neo4j.
Co-authored-by: Aadarsh A <aadarsh.ram@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool @aadarsh-ram , you are on the right path.
Although I would have concentrated first on "entry" not the rest, because here you run the risk of having to fix lots of same errors on each API, while you could learn first on entries, and then do the rest (it's just an advice).
There are things to separate and factorize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good @aadarsh-ram
I still request quite a lot of change so that we have a perfect code :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one single comment :-)
You understood previous comments very well.
Co-authored-by: Alex Garel <alex@garel.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @aadarsh-ram,
Let's merge :-)
What
Part of