feat: List all properties of an entry #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobeeakon
reviewed
Sep 1, 2022
taxonomy-editor-frontend/src/pages/editentry/ListAllProperties.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListAllProperties.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListAllProperties.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListAllProperties.jsx
Outdated
Show resolved
Hide resolved
| if (key.startsWith('prop')) { | ||
|
|
||
| // Removing "prop_" prefix from key to render only the name | ||
| const property_name = key.split('_').slice(1).join('_'); |
There was a problem hiding this comment.
what about doing this property_name extraction only when the property name is shown? I mean, inside the <Typography sx={{...}}>{property}:</Typography>. The renderedProperties doesn't seems to care if it has or not the preffix prop_, and the issue is that in the onChange you need to add it again
There was a problem hiding this comment.
@nobeeakon renderedProperties does care about the prefix prop_. The key-value pairs that have to be rendered on the webpage should have the prefix prop_. Hence, the appropriate checks have been done in the start.
taxonomy-editor-frontend/src/pages/editentry/ListAllProperties.jsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/editentry/ListAllProperties.jsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What