Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer pandas imports #515

Closed
wants to merge 1 commit into from
Closed

Defer pandas imports #515

wants to merge 1 commit into from

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Aug 25, 2022

Description

Unfortunately the wins won't happen until hgrecco/pint#1492 is finished.

>>> import sys, rdkit, openff.toolkit
>>> "pandas" in sys.modules
False
>>> import openff.units
>>> "pandas" in sys.modules
True

Checklist

  • Add tests
  • Lint
  • Update docstrings

@mattwthompson
Copy link
Member Author

Blocked by hgrecco/pint#1492

@mattwthompson mattwthompson marked this pull request as draft November 1, 2022 20:59
@mattwthompson
Copy link
Member Author

This should no longer be needed after Pint 0.21, but will need to test to be sure

@mattwthompson
Copy link
Member Author

Woo!

In [1]: >>> import sys, rdkit, openff.toolkit
   ...: >>> "pandas" in sys.modules
   ...:
Out[1]: False

In [2]: >>> import openff.units
   ...: >>> "pandas" in sys.modules
   ...:
Out[2]: False

@mattwthompson mattwthompson deleted the lazy-pandas branch April 16, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant