Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not raise bare Exception #1569

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Do not raise bare Exception #1569

merged 3 commits into from
Apr 6, 2023

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Apr 3, 2023 •
edited
Loading

I noticed a handful of cases in which important errors are triggered as raise Exception. We should not do this.

@codecov
Copy link

codecov bot commented Apr 3, 2023 •
edited
Loading

Codecov Report

Merging #1569 (5264080) into main (485ae2a) will increase coverage by 0.05%.
The diff coverage is 20.68%.

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review April 3, 2023 18:29
j-wags
j-wags approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - This is good to merge once releasenotes are updated!

@mattwthompson mattwthompson merged commit 3c22bc0 into main Apr 6, 2023
@mattwthompson mattwthompson deleted the no-exception branch April 6, 2023 20:40
@mattwthompson mattwthompson mentioned this pull request Apr 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags j-wags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattwthompson @j-wags