Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up conversion utilities already moved to openforcefield #247

Merged
merged 4 commits into from
Apr 6, 2017

Conversation

davidlmobley
Copy link
Contributor

Partially resolving #244 by removing utilities which has been moved to github.com/open-forcefield-group/openforcefield. Much more still to be done, but this removes some key duplication.

@davidlmobley
Copy link
Contributor Author

@bannanc - after opening this, I realized I perhaps went slightly too far, as these two files might actually belong in smarty:

  • filter_molecule_sets/ - code used to filter DrugBank database including some initial subsets that were not used in final smarty/smirky testing
  • oeb-to-FF-and-tripos-mol2.py - utility to convert oeb file with parm@Frosst atomtypes to two *.mol2 files with tripos and parm@frosst atomtypes

Do these belong here, or with the forcefield stuff?

@bannanc
Copy link
Collaborator

bannanc commented Apr 6, 2017

@davidlmobley

I think the molecule sets probably make the most sense to be here actually, including the oeb to mol2 script. We use them to test the smarty and smirky simulations, but they've also been used when developing the smirnoff force field

@davidlmobley
Copy link
Contributor Author

Thanks, @bannanc . Restored them here. Can you do a quick check when you have a chance then merge? (See also parallel PR openforcefield/openff-toolkit#10 -- with these two, everything in utilities should now be only in one place rather than two.)

@bannanc
Copy link
Collaborator

bannanc commented Apr 6, 2017

I think the molecule sets probably make the most sense to be here actually, including the oeb to mol2 script. We use them to test the smarty and smirky simulations, but they've also been used when developing the smirnoff force field

@davidlmobley I wrote that thinking I was on the openforcefield repo I think both of those things should be there. I'll see if I can revert both of these by one commit?
I'm not sure how to do that.

@davidlmobley davidlmobley merged commit d5d48f9 into master Apr 6, 2017
@bannanc bannanc deleted the mobley branch January 24, 2018 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants