Fix cross domain requests for static files with a querystring #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some static files are called with a query string. It breaks the effect of CORS headers to allow cross domain requests when static files are placed behing a CDN. Passing the query string to the origin fixes it.
The new 0.13 version of terraform requires a migration. We don't want to do it now so we need to pin it to v0.12.
madmatah
reviewed
Aug 19, 2020
madmatah
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Some static files are called with a query string. It breaks the effect of CORS headers to allow cross domain requests when static files are placed behing a CDN.
Proposal
Passing the query string to the origin fixes the issue.