✨(backend) add offer and price fields to courseRun #2466
Conversation
JoaoGarcao
force-pushed
the
JoaoGarcao/issue/2451/model-add-price
branch
from
d08ad9e
to
dde2d06
Compare
| @@ -623,6 +623,8 @@ def test_models_course_run_mark_dirty_any_field(self): | |||
| stub = CourseRunFactory( | |||
| sync_mode="manual", | |||
| catalog_visibility=CourseRunCatalogVisibility.COURSE_ONLY, | |||
| offer=CourseRunOffer.SUBSCRIPTION, | |||
There was a problem hiding this comment.
@JoaoGarcao You have to use the setting RICHIE_DEFAULT_COURSE_RUN_OFFER that you have added to to the settings.py
|
@JoaoGarcao to fix the |
| @@ -75,6 +75,8 @@ class Meta: | |||
| "state", | |||
| "enrollment_count", | |||
| "catalog_visibility", | |||
| "offer", | |||
| "price", | |||
There was a problem hiding this comment.
price field could be returned as a float not a string.
There was a problem hiding this comment.
I've made a change to this, but I'm not sure if it's in line with what you asked for.
sandbox/settings.py
Outdated
| RICHIE_DEFAULT_COURSE_RUN_OFFER = values.Value( | ||
| "free", | ||
| environ_name="RICHIE_DEFAULT_COURSE_RUN_OFFER", | ||
| environ_prefix=None, | ||
| ) | ||
|
|
||
| # Course run price currency value that would be shown on course detail page | ||
| RICHIE_DEFAULT_COURSE_RUN_PRICE_CURRENCY = values.Value( | ||
| "EUR", | ||
| environ_name="RICHIE_DEFAULT_COURSE_RUN_PRICE_CURRENCY", | ||
| environ_prefix=None, | ||
| ) | ||
|
|
||
| # Course run price value that would be shown on course detail page | ||
| RICHIE_DEFAULT_COURSE_RUN_PRICE = values.Value( | ||
| 0.0, | ||
| environ_name="RICHIE_DEFAULT_COURSE_RUN_PRICE", | ||
| environ_prefix=None, | ||
| ) |
There was a problem hiding this comment.
RICHIE_DEFAULT_COURSE_RUN_OFFER and RICHIE_DEFAULT_COURSE_RUN_PRICE look not used. Furthermore, I wonder if this is really useful to be able to override to default values through a settings. WDYT?
There was a problem hiding this comment.
I agree that the RICHIE_DEFAULT_COURSE_RUN_PRICE shouldn't be on a setting.
@JoaoGarcao the RICHIE_DEFAULT_COURSE_RUN_OFFER should be included only on the next PR that you are working.
JoaoGarcao
force-pushed
the
JoaoGarcao/issue/2451/model-add-price
branch
2 times, most recently
from
84083cc
to
78b87af
Compare
Add offer and price fields to courseRun displayed at admin view related to openfun#2445
JoaoGarcao
force-pushed
the
JoaoGarcao/issue/2451/model-add-price
branch
from
78b87af
to
8ee54a1
Compare
Add offer and price fields to courseRun displayed at admin view
related to #2445
1º task requested on issue #2451