Patch R-tree index triggers #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up of #661 drop _old_geom_notnull suffix from _update6 trigger and _old_geom_null suffix from _update7 trigger also: revising summary based on OAB feedback
rouault
reviewed
May 31, 2023
| @@ -60,6 +60,6 @@ See <<Clause_Critical>> for more information on critical changes and | |||
| |[yellow-background]#link:https://github.com/opengeospatial/geopackage/pull/661[#661]# | |||
| |[yellow-background]#S# | |||
| |[yellow-background]#Annex F.3# | |||
| |[yellow-background]#Deprecate update1 and update3 triggers, add update5, update6, and update7 triggers# | |||
| |[yellow-background]#Replace update1 trigger with update6 and update7 to support upsert operations# | |||
There was a problem hiding this comment.
the mention of update3 replaced by update5 should likely be kept, shouldn't it ?
There was a problem hiding this comment.
I'm ambivalent here. It is fully explained here.
There was a problem hiding this comment.
ok, doesn't matter much to me. Just wanted to check if that was accidentally removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #661
Swallows #663
drop _old_geom_notnull suffix from _update6 trigger and _old_geom_null suffix from _update7 trigger
also: revising summary based on OAB feedback