Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass met_model as a list to get_footprint #125

Merged
merged 2 commits into from
May 17, 2024

Conversation

brendan-m-murphy
Copy link
Contributor

  • Summary of changes

met_model can be passed as list in an ini file, to cover the case where two footprints are distiguished only by met model. The list must have the same length as the number of sites. Values of None will be ignored, so for sites where the met model doesn't matter, None can be passed.

  • Please check if the PR fulfills these requirements
  • Tests passing
  • Added an entry to the CHANGELOG.md file

`met_model` can be passed as list in an ini file, to
cover the case where two footprints are distiguished only
by met model. The list must have the same length as the number
of sites. Values of `None` will be ignored, so for sites where the
met model doesn't matter, `None` can be passed.
@brendan-m-murphy brendan-m-murphy marked this pull request as ready for review May 15, 2024 13:17
Copy link
Contributor

@joe-pitt joe-pitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for doing this!

@brendan-m-murphy brendan-m-murphy merged commit a48f35e into devel May 17, 2024
3 checks passed
@brendan-m-murphy brendan-m-murphy deleted the pass-met-model-as-list branch May 17, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants