Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ux] Night Mapping theme improvements follow-up #937

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

gacarrillor
Copy link
Collaborator

@gacarrillor gacarrillor commented Jun 21, 2024

  • Make sure text on ProgressBars is visible also for Night Mapping theme.
  • Model (.ili) icon

Some screenshots:

Screenshot from 2024-06-24 10-25-51

image

image

image

Before (Model icon):

image


Follow-up #928

@gacarrillor gacarrillor marked this pull request as ready for review June 24, 2024 17:31
@gacarrillor
Copy link
Collaborator Author

What's missing couldn't be solved due to a Qt bug and was posted as an issue: #939

QgisModelBaker/images/file_types/model.png Outdated Show resolved Hide resolved
QgisModelBaker/utils/gui_utils.py Outdated Show resolved Hide resolved
@gacarrillor gacarrillor force-pushed the night_mapping_theme_follow_up branch from fcb92c7 to cad4556 Compare June 25, 2024 00:02
@gacarrillor gacarrillor merged commit 5d2effd into master Jun 25, 2024
7 checks passed
@gacarrillor gacarrillor deleted the night_mapping_theme_follow_up branch June 25, 2024 14:10
@signedav
Copy link
Member

signedav commented Jun 27, 2024

Here a nice screeny maybe for the documenation:
Screenshot from 2024-06-27 12-18-24

Looks really nice!

And grey:
image

And default:
image

@gacarrillor
Copy link
Collaborator Author

Here a nice screeny maybe for the documenation

Nice! Yeah, it would be cool to advertise multi-theme support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants