Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shelly] New things are added to Inbox with wrong representation property #15398

Closed
markus7017 opened this issue Aug 10, 2023 · 0 comments · Fixed by #15798
Closed

[shelly] New things are added to Inbox with wrong representation property #15398

markus7017 opened this issue Aug 10, 2023 · 0 comments · Fixed by #15798
Assignees
@markus7017
Labels
bug An unexpected problem or unintended behavior of an add-on PR pending There is a pull request for resolving the issue

Comments

@markus7017
Copy link
Contributor

The binding ass new things to the Inbox using deviceName as representationProperty instead of serviceName. This could cause strange effects on adding things from the Inbox - they remain there even a new thing has been created.
@markus7017 markus7017 added bug An unexpected problem or unintended behavior of an add-on PR pending There is a pull request for resolving the issue labels Aug 10, 2023
@markus7017 markus7017 self-assigned this Aug 10, 2023
@markus7017 markus7017 mentioned this issue Aug 10, 2023
Closed
markus7017 added a commit to markus7017/openhab-addons that referenced this issue Aug 10, 2023
@markus7017
- openhab#15399: Rework device discovery and initialization: Use /she…
88b73ad 
…lly to

retrieve device attributes, thing discovery is now based on reported
device model id rather than service name. If is not recognized the
service name will be used as fallback. Even password protected things
are now created with the thing type matching the model rather than
shellydevice, which is still supported for backward compatibility.
- openhab#15398: Discovery result now uses representation property serviceName
rather than deviceName, which could case strange effects when adding
things from the Inbox
- openhab#15397: Security fix for Gen1: We don’t expose basic auth (BASE64
encoded password) anymore when not requested by the device (/shelly.auth
= true). Gen2 uses digest authentication, which is not affected by this
issues.
- openhab#15392: Version detection for Gen2 devices is fixed and now also
handles beta versions correctly (e.g. 1.0.0-beta6), they are displayed
correctly in Shelly Manager
- openhab#15359: Shelly BLU Motion is supported
- openhab#15396: Cleanup in Shelly Manager for actions and firmware upgrade,
which currently can’t be supported by the binding.
- openhab#15395: Gen2: Do not try to install BLU script on battery devices like
PlusHT
- openhab#15394: CoIoT attribute boost mode is now processed and results in a
channel update
- openhab#15393: Fix for TRV target temp not being initialized
- openhab#15392 Gen2: Upgrade to beta firmware by device fixed
- Code cleanup of duplicate device attributes, which causes a bunch of
dummy changes (/referred variables names have changed)
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>
markus7017 added a commit to markus7017/openhab-addons that referenced this issue Aug 10, 2023
@markus7017
The PR includes the following enhancements and fixes. Most changes are
736a722 
related to device discovery and initialization as well as BLU motion
support. The other topics are small fixes, we were able to catch a bunch
of them.
- openhab#15399: Rework device discovery and initialization: Use /shelly to
retrieve device attributes, thing discovery is now based on reported
device model id rather than service name. If is not recognized the
service name will be used as fallback. Even password protected things
are now created with the thing type matching the model rather than
shellydevice, which is still supported for backward compatibility.
- openhab#15398: Discovery result now uses representation property serviceName
rather than deviceName, which could case strange effects when adding
things from the Inbox
- openhab#15397: Security fix for Gen1: We don’t expose basic auth (BASE64
encoded password) anymore when not requested by the device (/shelly.auth
= true). Gen2 uses digest authentication, which is not affected by this
issues.
- openhab#15392: Version detection for Gen2 devices is fixed and now also
handles beta versions correctly (e.g. 1.0.0-beta6), they are displayed
correctly in Shelly Manager
- openhab#15359: Shelly BLU Motion is supported
- openhab#15396: Cleanup in Shelly Manager for actions and firmware upgrade,
which currently can’t be supported by the binding.
- openhab#15395: Gen2: Do not try to install BLU script on battery devices like
PlusHT
- openhab#15394: CoIoT attribute boost mode is now processed and results in a
channel update
- openhab#15393: Fix for TRV target temp not being initialized
- openhab#15392 Gen2: Upgrade to beta firmware by device fixed
- Code cleanup of duplicate device attributes, which causes a bunch of
dummy changes (/referred variables names have changed)
- README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>
@markus7017 markus7017 mentioned this issue Aug 10, 2023
Merged
@markus7017 markus7017 mentioned this issue Oct 22, 2023
Merged
@markus7017 markus7017 linked a pull request Oct 22, 2023 that will close this issue
[shelly] Fix resource leak, BLU script installation, TRV init, NPE on IPv6 mDNS discovery #15798
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markus7017 markus7017

Labels
bug An unexpected problem or unintended behavior of an add-on PR pending There is a pull request for resolving the issue
Projects
None yet
Milestone
No milestone
1 participant
@markus7017