Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ekey] initial contribution / oh1 migration #10996

Merged
merged 9 commits into from
Oct 12, 2021
Merged

[ekey] initial contribution / oh1 migration #10996

merged 9 commits into from
Oct 12, 2021

Conversation

hmerk
Copy link
Contributor

@hmerk hmerk commented Jul 14, 2021

Signed-off-by: Hans-Jörg Merk github@hmerk.de

This is the oh1 migration of the ekey binding.

community discussion can be found here
https://community.openhab.org/t/ekey-integration-into-openhab3-as-ekey-binding-is-deprecated-and-wont-be-available-for-oh3/112718

@hmerk
[ekey] initial contribution / oh1 migration
6ecfbdb 
Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
@hmerk hmerk requested a review from a team as a code owner July 14, 2021 08:40
@hmerk hmerk mentioned this pull request Jul 14, 2021
Closed
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/ekey-integration-into-openhab3-as-ekey-binding-is-deprecated-and-wont-be-available-for-oh3/112718/22

@hmerk hmerk added this to the 3.2 milestone Jul 14, 2021
@hmerk hmerk added oh1 migration Relates to migrating an openHAB 1 addon to openHAB 2 new binding If someone has started to work on a binding. For a new binding PR. labels Jul 14, 2021
@hmerk
Add examples to readme
7c33a66 
Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
@hmerk
add binding to bundles/pom.xml
c0f0f60 
Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jul 15, 2021
@hmerk
Copy link
Contributor Author

hmerk commented Jul 16, 2021

PR build failure seems not to be related to ekey binding, as it is marked green (passed).

@hmerk
remove Jenkins warnings
5f5e58a 
Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
@hmerk
fixed typos and wrong channel names
0418732 
Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
@hmerk
added missing channel to list
fbede8d 
Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
@hmerk hmerk added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jul 20, 2021
@hmerk
Copy link
Contributor Author

hmerk commented Jul 20, 2021

Starting rebuild as jenkins failure is not ekey related. Latest commits are only fixes in the Readme.

@hmerk hmerk requested a review from fwolter September 3, 2021 09:11
@hmerk
Copy link
Contributor Author

hmerk commented Sep 27, 2021

@fwolter I have seen you are busy with other reviews, but wold really appreciate if you could start with reviewing this one, as it is a oh1 migration....

@hmerk
Small changes after first review
0317bc3 
Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
Skinah
Skinah requested changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@Skinah Skinah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read all lines of code and will approve, thanks for the PR and contribution. Someone else will still take a look as I don't have merge rights so if you don't agree with something I suggested just leave it open until they come along.

@hmerk
Copy link
Contributor Author

hmerk commented Oct 7, 2021

@Skinah Thanks Matt for your review.
I have left comments on your remarks and will adress the last one today.
Others were mainly about trace logging, which should be no show stopper for a merge, as it is not uncommon to use it that way.

@hmerk
Small changes after second review
32381f5 
Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
@hmerk
Copy link
Contributor Author

hmerk commented Oct 7, 2021

@Skinah Thanks again Matt, I have adressed your last comment, so we should be ready for a final review.
@fwolter Fabian, could you start with your review please...

@hmerk
Refactored trace logging
98b5f4c 
Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
Skinah
Skinah approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@Skinah Skinah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hmerk
Copy link
Contributor Author

hmerk commented Oct 8, 2021

@Skinah Thanks for your review and approval Matthew !!!! Really appreciated !!

kaikreuzer
kaikreuzer approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hmerk, thanks for being so patient.
I've reviewed your code and it all looks good to me, so let us finally merge it!
Thanks for your contribution!

@kaikreuzer kaikreuzer merged commit f1e7f19 into openhab:main Oct 12, 2021
@hmerk
Copy link
Contributor Author

hmerk commented Oct 12, 2021

@kaikreuzer Thanks for approval and merge, really appreciated!

@hmerk hmerk deleted the ekey_binding branch October 12, 2021 19:58
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
@hmerk @frederictobiasc
[ekey] initial contribution / oh1 migration (openhab#10996)
107ce97 
* [ekey] initial contribution / oh1 migration

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
dschoepel pushed a commit to dschoepel/openhab-addons that referenced this pull request Nov 9, 2021
@hmerk @dschoepel
[ekey] initial contribution / oh1 migration (openhab#10996)
8c4cfc3 
* [ekey] initial contribution / oh1 migration

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
@hmerk @NickWaterton
[ekey] initial contribution / oh1 migration (openhab#10996)
2651217 
* [ekey] initial contribution / oh1 migration

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
@hmerk
[ekey] initial contribution / oh1 migration (openhab#10996)
3570269 
* [ekey] initial contribution / oh1 migration

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@hmerk
[ekey] initial contribution / oh1 migration (openhab#10996)
0249dd2 
* [ekey] initial contribution / oh1 migration

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skinah Skinah Skinah approved these changes

@kaikreuzer kaikreuzer kaikreuzer approved these changes

@fwolter fwolter Awaiting requested review from fwolter

Assignees
No one assigned
Labels
community approved new binding If someone has started to work on a binding. For a new binding PR. oh1 migration Relates to migrating an openHAB 1 addon to openHAB 2
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@hmerk @openhab-bot @kaikreuzer @Skinah