-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[imperihome] Remove org.apache.common #14441
Conversation
Signed-off-by: lsiepel <leosiepel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
@lolodomo - I don't think we should have "enhancement" label on these PR's since it's purely technical refactoring? With this label in will be mentioned in release notes. |
I think it is good to have any code change in the release notes. It can help users identifying what changes could have broken something. |
Are you sure? As that does not seem to be common practice in the past: https://github.com/openhab/openhab-addons/pulls?page=2&q=is%3Apr+is%3Aclosed+no%3Alabel many technicall code changes without tags |
I don't think that has been common until now, but of course there can be gray areas where we need to assess individually whether to mention or not. My impression so far has been not to mention small purely technical refactoring PR's (without expected user impact). @openhab/add-ons-maintainers, any opinions to have some common ground, so we don't continuously add/remove labels based on different rules? |
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: lsiepel <leosiepel@gmail.com>
Untested, minor refactoring only from code perspective