Resolve runbundles and fix tests #14588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wborn
requested review from
hmerk,
cweitkamp,
kaikreuzer,
svilenvul,
marcelrv,
davidgraeff,
ssalonen,
BjoernLange,
gerrieg,
a team,
andylintner,
jlaur and
andrewfg
as code owners
Related to: * openhab/openhab-core#3433 * openhab/openhab-core#3446 * openhab/openhab-core#3450 Some tests were updated because private lifecycle methods (annotated with @BeforeAll, @afterall, @beforeeach, or @AfterEach) now lead to an exception. See: https://junit.org/junit5/docs/current/release-notes/index.html#deprecations-and-breaking-changes-3 Signed-off-by: Wouter Born <github@maindrain.net>
wborn
force-pushed
the
resolve-runbundles-fix-tests
branch
from
fd8bfb4 to
7b72ebf
Compare
jlaur
approved these changes
Mar 12, 2023
kaikreuzer
added
rebuild
|
@wborn (putting aside the fact that this broke my PR #13570 yet again) .. .. as @kaikreuzer says "another effect of Java17 is that it (OH 4.0) does not include the Nashorn Javascript engine anymore" so perhaps you need to remove |
|
No because @kaikreuzer also says "Install the JavaScript Nashorn add-on ...". |
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
Related to: * openhab/openhab-core#3433 * openhab/openhab-core#3446 * openhab/openhab-core#3450 Some tests were updated because private lifecycle methods (annotated with @BeforeAll, @afterall, @beforeeach, or @AfterEach) now lead to an exception. See: https://junit.org/junit5/docs/current/release-notes/index.html#deprecations-and-breaking-changes-3 Signed-off-by: Wouter Born <github@maindrain.net>
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
Related to: * openhab/openhab-core#3433 * openhab/openhab-core#3446 * openhab/openhab-core#3450 Some tests were updated because private lifecycle methods (annotated with @BeforeAll, @afterall, @beforeeach, or @AfterEach) now lead to an exception. See: https://junit.org/junit5/docs/current/release-notes/index.html#deprecations-and-breaking-changes-3 Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
Some tests were updated because private lifecycle methods (annotated with
@BeforeAll,@AfterAll,@BeforeEach, or@AfterEach) now lead to an exception.See: https://junit.org/junit5/docs/current/release-notes/index.html#deprecations-and-breaking-changes-3